[lilv] Add new port #14080
Merged
[lilv] Add new port #14080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:new-port
NancyLi1013
approved these changes
Oct 16, 2020
|
Is this PR ready for review now? |
|
LGTM now. Thanks for your PR @DomClark. |
|
Thanks for your contribution! |
|
@DomClark have you contacted upstream about merging the CMakeLists.txt? |
|
@Be-ing I haven't, no. It relies on CMake versions of other libraries in the LV2 family, some of which are rather incomplete (I only implemented what I required), and don't follow upstream's packaging guidelines exactly (due to vcpkg's different requirements and aims). If you think doing so could be beneficial, though, by all means feel free to contact them. |
|
I did contact upstream. He is working on a new Meson build system for the LV2 libraries, so when that is released, the custom CMakeLists.txts in vcpkg can be dropped. |
|
Thanks - that's good to hear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [New Port Request] lilv #13211.
Which triplets are supported/not supported? Have you updated the CI baseline?
UWP is not supported. I have tested
x86-windows,x64-windows, andx64-windows-static; I would expect others to work too. The CI baseline has not been updated.Does your PR follow the maintainer guide?
Yes.