-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Enable Boost building with wasm32-emscripten #14102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update Port-Version in boost-locale CONTROL file?
From Port-Version: 1 to Port-Version: 2
@@ -1,10 +1,10 @@ | |||
# Automatically generated by boost-vcpkg-helpers/generate-ports.ps1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct: this file is supposed to be generated but there are no changes to the generator here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used generate-ports.ps1
now, but it's a bit uncharted territory for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the generator are missing.
} | ||
|
||
$per_port_data = @{ | ||
"fiber" = @{ "supports" = "windows&!uwp&!arm" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: "fiber" had "windows" instead of "!osx" here, while portfile had "!osx". Seems to compile at least on x64-linux though. Changed to !osx, as this is what users experience - as presume most users will just use CONTROL, not the .ps1 script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we probably inappropriately merged changes without the corresponding changes to the generator. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happens to the best of us :P
Are PR changes ok now?
The gmp failure is in the baseline, so merging this anyway. Thanks for your contribution! |
This PR allows for
boost:wasm32-emscripten
compilation.While most of Boost compiles already with Emscripten (wow!), few modules didn't, like
boost-locale
,boost-asio
,boost-coroutine
, etc.Did some hacky fixes to enable
boost-locale
compilation, and disabled dependency ofboost
to the other modules that don't yet work.Thanks to PR, these commands should work:
Note: this isn't probably the way yet, as seems that Boost allows for
toolset=emscripten
compilation (though, throwing cryptic Boost Jam/B2 errors when trying this from vcpkg), and this PR doesn't try to change currently usedtoolset=gcc
.