Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add SemVer and Date versioning schemes #14889

Merged
merged 16 commits into from
Dec 7, 2020
Merged

[vcpkg] Add SemVer and Date versioning schemes #14889

merged 16 commits into from
Dec 7, 2020

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Dec 2, 2020 •
edited
Loading

Vcpkg is now able to understand version-date and version-semver

Reference #11758

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Dec 2, 2020
ras0219
ras0219 reviewed Dec 3, 2020
View reviewed changes
ras0219
ras0219 approved these changes Dec 5, 2020
View reviewed changes
@vicroms vicroms changed the title [WIP][vcpkg] Add SemVer and Date versioning schemes [vcpkg] Add SemVer and Date versioning schemes Dec 5, 2020
@vicroms vicroms marked this pull request as ready for review December 5, 2020 07:53
ras0219
ras0219 suggested changes Dec 5, 2020
View reviewed changes
BillyONeal
BillyONeal reviewed Dec 6, 2020
View reviewed changes
ras0219
ras0219 approved these changes Dec 6, 2020
View reviewed changes
Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @BillyONeal's comment about locale is addressed.

@vicroms vicroms merged commit 53e6588 into microsoft:master Dec 7, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@vicroms
[vcpkg] Add SemVer and Date versioning schemes (microsoft#14889)
8e2f70b 
* [vcpkg] Add semver versioning scheme

* Remove unnecessary code

* Fix SemVer comparison and add sorting test

* Add date scheme

* PR comments

* Use a different column for date and semver schemes.

* Use locale agnostic conversion to long

* Add tests for version scheme change

* Validate version strings before parsing

* Format

* Improve error messages

* PR comments

* PR comments pt. 2
@vicroms vicroms deleted the versioning/schemes branch September 26, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vicroms @ras0219 @BillyONeal @JackBoosY