Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dav1d] Add dav1d AV1 decoder port #15009

Merged
merged 7 commits into from
Jan 25, 2021
Merged

[dav1d] Add dav1d AV1 decoder port #15009

merged 7 commits into from
Jan 25, 2021

Conversation

RichLogan
Copy link
Contributor

Adds dav1d AV1 decoder port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Struggling with MSVC underscore prefixes on x86-windows. Disabled support in manifest for now.

@ghost
Copy link

ghost commented Dec 8, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@RichLogan
Copy link
Contributor Author

I think that these are failing on linux due a bug in upstream meson. I will submit a PR to rev vcpkg's meson to try and resolve this.

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 9, 2020
NancyLi1013
NancyLi1013 suggested changes Dec 9, 2020
View reviewed changes
ports/dav1d/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

@RichLogan

Could you please sign CLA first?

@RichLogan RichLogan mentioned this pull request Dec 18, 2020
Merged
@RichLogan
Copy link
Contributor Author

Depends: #15200

@NancyLi1013 NancyLi1013 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 21, 2020
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 14, 2021
@JackBoosY
Copy link
Contributor

Can you continue this PR now?

@RichLogan RichLogan marked this pull request as draft January 15, 2021 18:30
@RichLogan RichLogan marked this pull request as ready for review January 17, 2021 13:02
@RichLogan
Copy link
Contributor Author

I think this is ready but I need some help with why x86-windows is failing on the "Validate Version Files" step.

@NancyLi1013
Copy link
Contributor

Could you please merge master and run command vcpkg x-add-version dav1d ?

Found the following errors:
Error: While validating port dav1d.
       Missing expected versions file at: C:\a\1\s\port_versions\d-\dav1d.json
       Run:

           vcpkg x-add-version dav1d

       to create the versions file.

To attempt to resolve all errors at once, run:

    vcpkg x-add-version --all

@RichLogan
Copy link
Contributor Author

@NancyLi1013 All done, thanks!

NancyLi1013
NancyLi1013 suggested changes Jan 19, 2021
View reviewed changes
ports/dav1d/portfile.cmake Outdated Show resolved Hide resolved
ports/dav1d/portfile.cmake Show resolved Hide resolved
@RichLogan RichLogan requested a review from NancyLi1013 January 19, 2021 09:37
@RichLogan
Copy link
Contributor Author

@NancyLi1013 Can this be merged now?

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 25, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @RichLogan.

@dan-shaw dan-shaw merged commit fc0d6b2 into microsoft:master Jan 25, 2021
@RichLogan RichLogan deleted the dav1d branch January 25, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichLogan @NancyLi1013 @JackBoosY @dan-shaw