Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib] Enable static build #15034

Closed
wants to merge 20 commits into from
Closed

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Dec 10, 2020

  • Enable static build on Windows.
  • Disable export function dllmain in glib and gobject.
  • Add missing definition GLIB_STATIC_COMPILATION and GOBJECT_STATIC_COMPILAT when building static.
  • Fix the static build of ports partially that depend on glib.

Fixes #3409.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Dec 10, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui December 11, 2020 05:43
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 15, 2020
@BillyONeal
Copy link
Member

/azp run

@BillyONeal BillyONeal closed this Dec 16, 2020
@BillyONeal BillyONeal reopened this Dec 16, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

For qt5-base:

find_library(GLIB_RELEASE NAMES glib-${GLIB_LIB_VERSION} PATHS "${CURRENT_INSTALLED_DIR}/lib" NO_DEFAULT_PATH)
find_library(GLIB_DEBUG NAMES glib-${GLIB_LIB_VERSION} PATHS "${CURRENT_INSTALLED_DIR}/debug/lib" NO_DEFAULT_PATH)
if(GLIB_RELEASE MATCHES "-NOTFOUND" OR GLIB_DEBUG MATCHES "-NOTFOUND")
set(GLIB_RELEASE "")
set(GLIB_DEBUG "")
endif()

Here we must add glib dependencies during static build, or directly use find_package to find zlib and use its targets.

@BillyONeal
Copy link
Member

Sorry about the qt issue @JackBoosY, I'm hoping to look at it soon

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Dec 28, 2020
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 20, 2021
@PhoebeHui PhoebeHui marked this pull request as draft January 22, 2021 02:23
@JackBoosY
Copy link
Contributor Author

Close this PR temporary.

@JackBoosY JackBoosY closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:different-pr This PR or Issue depends on a PR which has been filed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glib:x64-windows-static failing
3 participants