[vcpkg baseline][cppcms] Fix issue with detecting Python 2. #15473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
approved these changes
Jan 6, 2021
|
Thanks for this PR! I will test it manually later. |
JackBoosY
added
the
category:port-bug
JackBoosY
changed the title
JackBoosY
suggested changes
Jan 6, 2021
|
Tiny and effective, thanks! |
JackBoosY
approved these changes
Jan 6, 2021
|
Ping @vicroms for merge this PR quickly. |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jan 7, 2021
[vcpkg baseline][cppcms] Fix issue with detecting Python 2. (microsoft#15473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with detection of Python 2 in the cppcms port. Ping @JackBoosY
What does your PR fix?
The upstream CMakeLists were using
find_program()to find the Python executable instead offind_package(). This can result in the Python 3 interpreter built by the python3 port to be selected in some situations. We fix this by passing the path to Python directly to the CMake cache.Which triplets are supported/not supported? Have you updated the CI baseline?
No change.
Does your PR follow the maintainer guide?
Yes