[fbgemm] create a new port #16346
Merged
[fbgemm] create a new port #16346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it seems like Possible reference? #15404 |
NancyLi1013
added
the
category:new-port
|
You may use this way to find |
|
Note for 0026248 x86-windowsIntrinsic x64-uwpSeems like x64-windows-static-md
|
* remove /MT /MD customization * remove deprecated warnings for asmjit
* uwp can't be supported with cpuinfo link failure * x86 SIMD may become available in future update
NancyLi1013
suggested changes
Feb 23, 2021
|
I agree. I will create PR to fbgemm mainstream.
…On Tue, Feb 23, 2021, 11:38 AM NancyLi1013 ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In ports/fbgemm/portfile.cmake
<#16346 (comment)>:
> + fix-cmakelists.patch
+ update-asmjit-usage.patch
+)
+
+vcpkg_configure_cmake(
+ SOURCE_PATH ${SOURCE_PATH}
+ PREFER_NINJA
+ OPTIONS
+ -DUSE_SANITIZER=OFF
+ -DFBGEMM_BUILD_TESTS=OFF
+ -DFBGEMM_BUILD_BENCHMARKS=OFF
+ -DPYTHON_EXECUTABLE=${PYTHON3} # inject the path instead of find_package(Python) while configuration
+)
+vcpkg_install_cmake()
+vcpkg_copy_pdbs()
+vcpkg_fixup_cmake_targets(CONFIG_PATH share/cmake/${PORT} TARGET_PATH share/${PORT})
⬇️ Suggested change
-vcpkg_fixup_cmake_targets(CONFIG_PATH share/cmake/${PORT} TARGET_PATH share/${PORT})
+vcpkg_fixup_cmake_targets(CONFIG_PATH share/cmake/${PORT})
It's unnecessary to specify TARGET_PATH, since it will default to share/${PORT}
. Please see
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_fixup_cmake_targets.md
.
------------------------------
In ports/fbgemm/vcpkg.json
<#16346 (comment)>:
> @@ -0,0 +1,11 @@
+{
+ "name": "fbgemm",
+ "version-string": "2021-02-21",
⬇️ Suggested change
- "version-string": "2021-02-21",
+ "version-date": "2021-02-21",
The field might be updated as version-date, please see the doc
https://github.com/microsoft/vcpkg/blob/master/docs/users/versioning.getting-started.md#manifest-changes
------------------------------
In versions/f-/fbgemm.json
<#16346 (comment)>:
> @@ -0,0 +1,9 @@
+{
+ "versions": [
+ {
+ "git-tree": "1afc730a345b6265a70e756850b5a212e67a25db",
+ "version-string": "2021-02-21",
⬇️ Suggested change
- "version-string": "2021-02-21",
+ "version-date": "2021-02-21",
------------------------------
In ports/fbgemm/portfile.cmake
<#16346 (comment)>:
> @@ -0,0 +1,30 @@
+vcpkg_fail_port_install(ON_ARCH "x86" ON_TARGET "uwp")
+
+# The project's CMakeLists.txt uses Python to select source files. Check if it is available in advance.
+vcpkg_find_acquire_program(PYTHON3)
+
+vcpkg_from_github(
+ OUT_SOURCE_PATH SOURCE_PATH
+ REPO pytorch/fbgemm
+ REF 975e41df8170115129abc524c225ddb88ec686dd
+ SHA512 2ee8b1464b29cd7ceb36665188f1b03e20d2c476b74fd81d2e3104a8e8f87196eca4497e7cb507eac576e717df8f306d05cc81a7122ed046814a171f6cfbe7b1
+ PATCHES
+ fix-cmakelists.patch
+ update-asmjit-usage.patch
Can you submit these changes to upstream?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16346 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLSYE7OAAGGMYBEKCQGPGLTAMIIZANCNFSM4X62LGUQ>
.
|
|
Seems like pytorch/FBGEMM#520 may need some time to be reviewed. Wish the work goes well... |
|
Waiting for pytorch/FBGEMM#538 |
* removed asmjit related patch files
NancyLi1013
approved these changes
Mar 18, 2021
|
LGTM now, thanks for your efforts @luncliff. |
ras0219-msft
approved these changes
Mar 19, 2021
| if(MSVC) | ||
| - set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4244 /wd4267 /wd4305 /wd4309") | ||
| - if(FBGEMM_LIBRARY_TYPE STREQUAL "static") | ||
| + set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4244 /wd4267 /wd4305 /wd4309 /wd4703") |
There was a problem hiding this comment.
For future reference: it would be best to completely disable warnings as errors in vcpkg instead of maintaining a specific list of disabled warnings.
This was referenced Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
There was no port request for this project.
This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the
libtorchport.Which triplets are supported/not supported? Have you updated the CI baseline?
The project's CI only checks Linux. At a glance, the triplet support should be an intersection of
asmjitandcpuinfo.I will update
"supports"after more checks.x64-osxx64-linuxx64-windowsx86-windowsDoes your PR follow the maintainer guide?
The library doesn't have a tag. I snapshoted the source code with
"version-string": 2021-02-21vcpkg format-manifest... we use the date that the commit was accessed by you, formatted as
YYYY-MM-DD.