Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][urho3d] Fix dependency readline #22321

Merged

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jan 4, 2022

  1. Fix find dependency readline: add feature readline and option URHO3D_ENABLE_READLINE.
    Fix use readline libraries: add readline's dependency curses:
: && /Library/Developer/CommandLineTools/usr/bin/cc -mtune=generic -fPIC -march=native -msse3 -pthread -Qunused-arguments -fcolor-diagnostics -Wno-argument-outside-range -g -DDEBUG -D_DEBUG -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names  Source/ThirdParty/Lua/CMakeFiles/lua_interpreter.dir/src/lua.c.o -o bin/lua  Source/ThirdParty/Lua/libLua.a  -lm  /Users/vagrant/Data/installed/x64-osx/debug/lib/libreadline.a && :
Undefined symbols for architecture x86_64:
  "_BC", referenced from:
      __rl_init_terminal_io in libreadline.a(terminal.c.o)
  "_PC", referenced from:
      __rl_init_terminal_io in libreadline.a(terminal.c.o)
  "_UP", referenced from:
      __rl_init_terminal_io in libreadline.a(terminal.c.o)
  "_tgetent", referenced from:
      __rl_init_terminal_io in libreadline.a(terminal.c.o)
  "_tgetflag", referenced from:
      __rl_init_terminal_io in libreadline.a(terminal.c.o)
  "_tgetnum", referenced from:
      __rl_get_screen_size in libreadline.a(terminal.c.o)
  "_tgetstr", referenced from:
      _get_term_capabilities in libreadline.a(terminal.c.o)
  "_tgoto", referenced from:
      _open_some_spaces in libreadline.a(display.c.o)
      _delete_chars in libreadline.a(display.c.o)
  "_tputs", referenced from:
      __rl_backspace in libreadline.a(terminal.c.o)
      __rl_cr in libreadline.a(terminal.c.o)
      _rl_ding in libreadline.a(terminal.c.o)
      __rl_standout_on in libreadline.a(terminal.c.o)
      __rl_standout_off in libreadline.a(terminal.c.o)
      __rl_enable_meta_key in libreadline.a(terminal.c.o)
      __rl_disable_meta_key in libreadline.a(terminal.c.o)
      ...
ld: symbol(s) not found for architecture x86_64

Already tested this feature on Windows and OSX.

  1. Add new port readline-unix to enable Linux support and replace port readline-osx, which use make buildsystem.

Related: #21790.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 4, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 4, 2022
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 4, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for readline-unix but no changes to version or port version.
-- Version: 8.1
-- Old SHA: 2c787a8b6551d7a7c02d469abb84262138a72e36
-- New SHA: e2ef4d4f472d6fe4f36009032dfdd3279a50c754
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@strega-nil-ms strega-nil-ms force-pushed the dev/jack/fix-baseline-20210104 branch from af135d6 to 9c14af0 Compare January 5, 2022 03:53
@strega-nil-ms strega-nil-ms merged commit b68f3cc into microsoft:master Jan 5, 2022
@strega-nil-ms
Copy link
Contributor

Thanks jack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants