Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open62541] don't force static CRT anymore #35419

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

JulZimmermann
Copy link
Contributor

Don't force the use of static CRT on Windows anymore.

This is a fix for costume triplets using something like this:

set(VCPKG_LIBRARY_LINKAGE static)
set(VCPKG_CRT_LINKAGE dynamic)

Without this PR the post-build validation outputs:

warning: The following binaries should use the Dynamic Debug (/MDd) CRT.
  C:\dev\vcpkg\packages\open62541_x64-windows-v143\debug\lib\open62541d.lib links with: Static Debug (/MTd)
To inspect the lib files, use:
  dumpbin.exe /directives mylibfile.lib
warning: The following binaries should use the Dynamic Release (/MD) CRT.
  C:\dev\vcpkg\packages\open62541_x64-windows-v143\lib\open62541.lib links with: Static Release (/MT)
To inspect the lib files, use:
  dumpbin.exe /directives mylibfile.lib
error: Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: C:\dev\vcpkg_ports\ports\open62541\portfile.cmake
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL self-assigned this Dec 1, 2023
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Dec 1, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 1, 2023
@vicroms vicroms merged commit af6b93a into microsoft:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants