Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[poco] update to 1.13.0 #35918

Merged
merged 4 commits into from
Jan 24, 2024
Merged

[poco] update to 1.13.0 #35918

merged 4 commits into from
Jan 24, 2024

Conversation

Cheney-W
Copy link
Contributor

Fixes #35872

Rename arc -> poco_arc pocoproject/poco@922fb39

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Dec 29, 2023
@Krzmbrzl
Copy link
Contributor

Krzmbrzl commented Dec 31, 2023 •
edited
Loading

To me it seems like the 1.13 release of Poco can't properly deal with disabling the new SQL parser as the header is included in other headers in Data like e.g. Statement.h but the SQLParser.h depends on the conditionally excludable subdirectory in the source tree. When it is excluded, it won't get installed and thus the includes from the installed SQLParser.h can't find the necessary files.

See also pocoproject/poco#4378

@Cheney-W Cheney-W mentioned this pull request Jan 5, 2024
Closed
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Jan 5, 2024
@Cheney-W Cheney-W marked this pull request as ready for review January 8, 2024 02:11
LilyWangLL
LilyWangLL previously approved these changes Jan 9, 2024
View reviewed changes
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 9, 2024
@JavierMatosD JavierMatosD marked this pull request as draft January 9, 2024 18:57
@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2024
@Cheney-W Cheney-W marked this pull request as ready for review January 19, 2024 02:31
@Cheney-W Cheney-W requested a review from JavierMatosD January 19, 2024 02:31
@JavierMatosD JavierMatosD merged commit c0bc859 into microsoft:master Jan 24, 2024
@Cheney-W Cheney-W deleted the Dev/Cheney/35872 branch January 25, 2024 06:16
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 29, 2024
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
@Cheney-W @TomKatom
[poco] update to 1.13.0 (microsoft#35918)
2a56def 
* [poco] update to 1.13.0

* Disable sql-parser

* Fix missing sql-parser/src/SQLParser.h

* Copy include files of sql-parser in portfile.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@JavierMatosD JavierMatosD JavierMatosD approved these changes

@LilyWangLL LilyWangLL LilyWangLL left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[poco] update to <1.13.0>
5 participants
@Cheney-W @Krzmbrzl @dg0yt @JavierMatosD @LilyWangLL