-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrade and Magnum on Linux #3611
Conversation
Removed ".exe" extension for executables on Linux. Removed default feature magnum[windowlesswglapplication] which works only on Windows.
@lecopivo ohoo, thanks! This was on my roadmap (I even have a dirty WIP patch lying around), but you were faster :) Just one note: there's a builtin Removing the windows-specific default feature makes sense for now, however in the long run I actually wanted to have system-specific |
Oh, um, just in case I wasn't clear and it's blocking the merge (sorry): from my side it's completely fine to merge the changes in their current form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, too!
@alexkaratarakis @ras0219-msft any chance to get this merged? :) Thanks a lot! |
Sorry for taking so long on this and thanks for the PR! Unfortunately, the portfile isn't a "full" CMake context, so some settings like |
Ah, I see. Thanks a lot for the merge! 👍 |
To get corrade and magnum working on Linux I had to do a minor change.
magnum[windowlesswglapplication]
which is Windows onlyI have tested it on few examples and it worked without a problem. However, a more through examination to test all possible plugins and extensions is probably necessary.