[influxdb-cxx] Move headers due to conflict with Proxy.h #41452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
added
category:port-bug
LilyWangLL
previously approved these changes
Oct 10, 2024
BillyONeal
changed the title
BillyONeal
force-pushed
the
influxdb-cxx
branch
from
173bca2 to
6053a3b
Compare
LilyWangLL
approved these changes
Oct 22, 2024
data-queue
approved these changes
Oct 23, 2024
|
There's an update of the offa/influxdb-cxx#268 PR which adds an option for the new path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #41435
An existing issue where
libproxyandinfluxdb-cxxboth try to takeinclude/Proxy.h/include/proxy.hwent undetected before microsoft/vcpkg-tool#1483 . The vcpkg maintainers discussed this and believe thatlibproxyshould be the owner ofinclude/[Pp]proxy\.h. It's both in the name and appears to be a much more widely used component.We are going to skip
influxdb-cxxin CI testing for now to unblock making our thrice-weekly CI runs green./cc @draveness @autoantwort @offa
We're going to giveinfluxdb-cxx's maintainers 60 days to respond by hopefully renaming the headers in question. I've also filed a PR that does that to hopefully help: offa/influxdb-cxx#263 . If there is no response in that time we'll move to removeinfluxdb-cxxfrom the registry.Upstream made changes: offa/influxdb-cxx#264 / offa/influxdb-cxx#268