[vcpkg baseline][openxr-loader] Fix config error #42567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2024 03:16
JonLiu1993
added
category:port-bug
BillyONeal
reviewed
Dec 6, 2024
|
|
||
| include(CMakeFindDependencyMacro) | ||
| find_dependency(Threads) | ||
| +find_dependency(jsoncpp CONFIG) |
There was a problem hiding this comment.
Agreed; upstream says NO_MODULE:
but this is documented to be the same as CONFIG: https://cmake.org/cmake/help/latest/command/find_package.html#full-signature
BillyONeal
approved these changes
Dec 6, 2024
Unrelated to brotli. qtquick3d still has an installation order problem. The recent openxr-loader update was pulled out of #42080, and I didn't notice the jsoncpp issue because there I disabled qtquick3d's use of openxr. qtquick3d is meant to get a feature to control openxr usage. |
|
Cherry-picked into #42588. |
|
Don't merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
qtquick3dfailedUndefined _BrotliEncoderCompressStream, https://dev.azure.com/vcpkg/public/_build/results?buildId=110038&view=resultsAdd function
find_dependency(jsoncpp CONFIG)to port openxr-loaderChecklist
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.Test
The port installation tests pass with the following triplets: