Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFCGAL] Add new port #43512

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[SFCGAL] Add new port #43512

wants to merge 7 commits into from
+63 −0

Conversation

lbartoletti
Copy link

@lbartoletti lbartoletti commented Jan 28, 2025 •
edited
Loading

This PR supersedes #35831 and uses SFCGAL to 2.0.0

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

lbartoletti and others added 5 commits December 22, 2023 10:10
@lbartoletti
[NEW] SFCGAL
2cbe1cc 
SFCGAL is a C++ wrapper library around CGAL with the aim of supporting ISO
19107:2013 and OGC Simple Features Access 1.2 for 3D operations.

SFCGAL provides standard compliant geometry types and operations, that can be
accessed from its C or C++ APIs. PostGIS uses the C API, to expose some
SFCGAL's functions in spatial databases

https://gitlab.com/sfcgal/SFCGAL
https://sfcgal.org/
@lbartoletti
replace vcpkg_install_cmake by vcpkg_cmake_install
7da5c28
@lbartoletti
exclude 32bits
12513a2
@lbartoletti
update versions/s-/sfcgal.json
f2b0ab2
@lbartoletti
Merge branch 'microsoft:master' into sfcgal
9ba0c4c
@lbartoletti lbartoletti force-pushed the sfcgal branch 6 times, most recently from 51c1bdd to 8f81ff2 Compare January 28, 2025 09:56
@dg0yt
Copy link
Contributor

dg0yt commented Feb 1, 2025

No, tried in 8762642, but x86 complains about an error .
I'll revert this commit.

Actually it built correctly. The only failing check was for the entry in versions. This has to be updated with vcpkg x-add-version --overwrite-version sfcgal.

@lbartoletti
Copy link
Author

No, tried in 8762642, but x86 complains about an error .
I'll revert this commit.

Actually it built correctly. The only failing check was for the entry in versions. This has to be updated with vcpkg x-add-version --overwrite-version sfcgal.

Indeed, thank you!

@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 5, 2025
@jimwang118 jimwang118 changed the title [NEW] SFCGAL [SFCGAL] Add new port Feb 5, 2025
@jimwang118
Copy link
Contributor

Usage test passed with x64-windows triplet.

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Feb 5, 2025
BillyONeal
BillyONeal reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new port!

ports/sfcgal/portfile.cmake
@@ -0,0 +1,31 @@
# Header only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are .cpps in https://gitlab.com/sfcgal/SFCGAL/-/tree/master/src?ref_type=heads , are you sure it's header only?

ports/sfcgal/portfile.cmake
HEAD_REF master
)

set(VCPKG_POLICY_ALLOW_EMPTY_FOLDERS enabled)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost certainly incorrect, why do there need to be empty folders?

ports/sfcgal/portfile.cmake
@@ -0,0 +1,31 @@
# Header only
vcpkg_buildpath_length_warning(37)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only asking because the line directly above it looks like it might be copy pasta: where did 37 come from? Can you point to the file that creates the length issue?

@BillyONeal BillyONeal marked this pull request as draft February 6, 2025 01:36
@jimwang118 jimwang118 removed the info:reviewed Pull Request changes follow basic guidelines label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms left review comments

@BillyONeal BillyONeal BillyONeal left review comments

Assignees

@jimwang118 jimwang118

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbartoletti @dg0yt @jimwang118 @BillyONeal @vicroms