Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crashpad] fix mac build #43516

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[crashpad] fix mac build #43516

wants to merge 1 commit into from
+13 −2

Conversation

autoantwort
Copy link
Contributor

Fixes #43515

dg0yt
dg0yt reviewed Jan 28, 2025
View reviewed changes
ports/crashpad/portfile.cmake
Comment on lines +13 to +17
x_vcpkg_get_python_packages(OUT_PYTHON_VAR PYTHON3
PYTHON_EXECUTABLE "${PYTHON3}"
PYTHON_VERSION "3"
PACKAGES setuptools
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: x_vcpkg_get_python_packages doesn't support asset caching.

@vicroms vicroms marked this pull request as draft January 30, 2025 08:37
@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@vicroms vicroms vicroms approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[crashpad] Build failure on arm64-osx
4 participants
@autoantwort @vicroms @dg0yt @WangWeiLin-MV