More KF5 ports added #4652
More KF5 ports added #4652
Conversation
|
|
NebuHiiEjamu
changed the title
NebuHiiEjamu
changed the title
|
Looking forward to this PR; Kate is <3 |
|
I'm not sure how essential, if at all, the files in bin/data are. I went ahead and removed the *.desktop and *.service files since those are Linux specific, however. After I get KWrite/Kate to build with these, I'll try Okteta and its dependents also since I personally like what it offers as a hex editor. I'm trying to build KF5Sonnet, but its utility, parsetrigrams.exe, seems to fail to execute, leaving an empty trigrams.map file. I tried the command manually and it outputs a populated trigrams.map file. I'm not sure what the problem is, but I think the issue is somewhere in data/CMakeLists.txt. Committed what I have so far |
…to avoid conflict with previous version.
|
I'm just going to commit what works. I didn't achieve my goal, but I still got a lot of new ports in, so... I'm going to submit this for review. I think the problem here is VCPkg disallows EXEs in the bin/ path and additional files in the tools/[existing installed port] paths. |
|
@NebuHiiEjamu Nice work. Was going to do this myself but did not have much time. |
|
Thanks. It's pretty much ready for review @ras0219-msft. I didn't get it ALL done because the way vcpkg maintains the bin/ directory makes it impossible. |
|
can this be merged ? |
|
I've said it's ready for review but none of the repo managers seem to notice and there's no contact info for them. |
|
@ras0219 @ras0219-msft Any review ? |
|
|
|
@ras0219 @ras0219-msft Any review ? |
|
The original PR branch has been deleted so it is not possible to run a CI build for it. |
|
Wait, if I delete my fork after submitting the PR, the PR is lost too? |
|
@NebuHiiEjamu kind of. We are unable to push to the PR branch, so therefore it cannot progress. We would absolutely love to have these changes, so feel free to create another PR! You and @cenit can take useful commits from each other's PR, and that way you will both have your own CI results whenever a change is made. Thanks! |
|
I will close my Pr the moment you restore yours. No way I want to hide your work!! I was fearing you were loosing interest in vcpkg due to waiting |
|
Ahh bummer, okay |
|
@NebuHiiEjamu keep working on the ports! |
| Source: editorconfig-core-c | ||
| Version: 0.12.2 | ||
| Description: EditorConfig core code written in C (for use by plugins supporting EditorConfig parsing) | ||
| Build-Depends: pcre |
There was a problem hiding this comment.
Could you please add Homepage here?
| @@ -0,0 +1,23 @@ | |||
| include(vcpkg_common_functions) | |||
There was a problem hiding this comment.
include(vcpkg_common_functions) is no longer needed.
Could you please remove this line?
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/share/man) | ||
| file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/editorconfig-core-c RENAME copyright) |
There was a problem hiding this comment.
Could you update
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/editorconfig-core-c RENAME copyright)
as
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?
|
Hi @NebuHiiEjamu |
|
Hi @NebuHiiEjamu |
|
Pinging @NebuHiiEjamu |
|
@NancyLi1013 The original branch is lost, so this PR is unrecoverable. That's why I created #7075... |
|
@cenit Thanks for your friendly reminder. @NebuHiiEjamu Closing this PR due to above causes. Please feel free to reopen this if you can continue to do the work for this PR. Thanks again for your contribuation to vcpkg. |
Will eventually be adding all dependencies needed to build the Kate text editor that aren't currently ports.