Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gtk]Fix missing resource files issue. #7942

Closed
wants to merge 2 commits into from

Conversation

JackBoosY
Copy link
Contributor

Complete the manifest generation step by viewing gtk's msvc project file and add the manifest to the build using CMakelists.txt.

Related: #6554.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 28, 2019
@JackBoosY
Copy link
Contributor Author

@NNemec Can you help me to test it?

Thanks.

@NNemec
Copy link
Contributor

NNemec commented Aug 28, 2019

@JackBoosY thanks for the work, but sorry, I will not be able to help on this. The project where I stumbled over this has been on ice for a few months and I have no idea when I will pick it up again.

@JackBoosY
Copy link
Contributor Author

@NNemec Can you give me some test code first?

Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review September 16, 2019 02:20
@JackBoosY JackBoosY added wip and removed wip labels Sep 16, 2019
@JackBoosY
Copy link
Contributor Author

Close this PR because we need to change the compiler mode to msbuild.

@JackBoosY JackBoosY closed this Nov 6, 2019
@JackBoosY JackBoosY deleted the dev/jack/6554 branch November 6, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants