Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] Add python64 bit. #7964

Merged
merged 17 commits into from
Feb 4, 2020
Merged

[tools] Add python64 bit. #7964

merged 17 commits into from
Feb 4, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 29, 2019 •
edited
Loading

  1. Add 64 bit python2/python3.
  2. Choose the different python version depending on the architecture.

Related: #7411.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 29, 2019
@JackBoosY JackBoosY requested a review from Rastaban August 29, 2019 09:34
@JackBoosY JackBoosY mentioned this pull request Aug 29, 2019
Closed
@JackBoosY JackBoosY marked this pull request as ready for review September 3, 2019 02:04
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Sep 23, 2019 •
edited
Loading

@cbezault Please restart CI and test all ports.

Thanks.

@Rastaban
Copy link
Contributor

Rastaban commented Sep 24, 2019 •
edited
Loading

This looks good to me so far.

I started a full rebuild test for windows here: https://dev.azure.com/vcpkg/public/_build/results?buildId=14308

@cbezault cbezault assigned grdowns and unassigned cbezault Oct 2, 2019
@JackBoosY
Copy link
Contributor Author

@grdowns can you restart CI and test all ports?
This time is very busy, so this PR is not processed, and the last CI result has expired.

@vicroms
Copy link
Member

vicroms commented Oct 30, 2019

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@JackBoosY
Copy link
Contributor Author

/azp run

1 similar comment
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

@grdowns Consider to merge this PR?

@vicroms
Copy link
Member

vicroms commented Nov 25, 2019

We should test all ports that use find_acquire_program(PYTHON3|PYTHON2)

@vicroms vicroms changed the title [tools]Add python64 bit. [tools] Add python64 bit. Nov 26, 2019
@NancyLi1013 NancyLi1013 mentioned this pull request Nov 28, 2019
Closed
@JackBoosY
Copy link
Contributor Author

/azp run

@PhoebeHui PhoebeHui self-assigned this Jan 14, 2020
PhoebeHui
PhoebeHui requested changes Jan 16, 2020
View reviewed changes
@PhoebeHui
Copy link
Contributor

The CI testing failed, could you update the ci baseline file?

##[error] REGRESSION: shiva-sfml:x64-windows
##[error] PASSING, REMOVE FROM FAIL LIST: shiva:x64-windows (C:\vsts_work\3\s\scripts\ci.baseline.txt)

NancyLi1013
NancyLi1013 suggested changes Jan 16, 2020
View reviewed changes
@JackBoosY JackBoosY mentioned this pull request Jan 22, 2020
Closed
@vicroms
Copy link
Member

vicroms commented Jan 30, 2020

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 7964 in repo microsoft/vcpkg

@vicroms
Copy link
Member

vicroms commented Feb 3, 2020

/azp run

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Feb 3, 2020 •
edited
Loading

CMake Error at D:/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE)
Call Stack (most recent call first):
D:/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
D:/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/share/cmake-3.14/Modules/FindPythonInterp.cmake:160 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
C:/vsts/_work/4/s/scripts/buildsystems/vcpkg.cmake:285 (_find_package)
C:/vsts/_work/4/s/installed/x64-windows/share/cmake/pybind11/FindPythonLibsNew.cmake:60 (find_package)
C:/vsts/_work/4/s/scripts/buildsystems/vcpkg.cmake:285 (_find_package)
C:/vsts/_work/4/s/installed/x64-windows/share/cmake/pybind11/pybind11Tools.cmake:16 (find_package)
C:/vsts/_work/4/s/installed/x64-windows/share/cmake/pybind11/pybind11Config.cmake:100 (include)
C:/vsts/_work/4/s/scripts/buildsystems/vcpkg.cmake:285 (_find_package)
modules/python/CMakeLists.txt:4 (find_package)

Fixing..

@JackBoosY
Copy link
Contributor Author

Since shiva-sfml does not match the dependency entt version, regression will be resolved in the next update of shiva-sfml.

@vicroms vicroms merged commit fa022fb into microsoft:master Feb 4, 2020
@JackBoosY JackBoosY deleted the dev/jack/7411 branch February 5, 2020 01:30
KineticTheory pushed a commit to KineticTheory/vcpkg that referenced this pull request Feb 17, 2020
@JackBoosY @vicroms @KineticTheory
[tools] Add python64 bit. (microsoft#7964)
d18f962 
* [tools]Add python64 bit.

* [pybind11/shiva]Add version number.

* [duktape]Fix build error using python64 bit.

* [duktape]Fix python2 path.

* [duktape]Fix duketape build: using python2 tools.

* Change subdirs and archive names for PYTHON2 and PYTHON3

* [duktape] Update version info

* [shiva] Add homepage

* update baseline

* update baseline

Co-authored-by: Victor Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui requested changes

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

@Rastaban Rastaban Awaiting requested review from Rastaban

Assignees

@ras0219-msft ras0219-msft

@PhoebeHui PhoebeHui

@grdowns grdowns

@NancyLi1013 NancyLi1013

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JackBoosY @Rastaban @vicroms @PhoebeHui @NancyLi1013 @cbezault @ras0219-msft @grdowns