Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow synchronous methods to have the suffix 'Synchronously' #336

Closed
wants to merge 1 commit into from

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Aug 5, 2018

Closes #331

@AArnott
Copy link
Member

AArnott commented Aug 7, 2018

In #331 you said Roslyn follows this pattern:

T SomeMethodSynchronous();
Task<T> SomeMethodAsync();

Notice that the suffix is Synchronous whereas this PR recognizes Synchronously (-ly ending).

So is this really fixing anything?

@sharwell
Copy link
Member Author

sharwell commented Aug 7, 2018

The suffix used there is Synchronously:

https://github.com/dotnet/roslyn/blob/f2c441274de1620496975ee223ec255c13bcafaa/src/Workspaces/Core/Portable/Workspace/Solution/TextDocument.cs#L83

It's unclear whether Synchronous should be allowed as well.

@AArnott
Copy link
Member

AArnott commented Dec 1, 2018

I'm going to close due to the build validation failure, the merge conflicts, and the open question on the original issue. Let's follow up on the issue and either close that, or re-open this PR when it's ready.

@AArnott AArnott closed this Dec 1, 2018
AArnott pushed a commit that referenced this pull request Jan 12, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants