Substantial perf improvement for VSTHRD010 analyzer #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#701: a massive perf issue with VSTHRD010
BertanAygun
approved these changes
Oct 30, 2020
AArnott
commented
Oct 30, 2020
| @@ -201,9 +203,30 @@ void MarkMethod(IMethodSymbol method) | |||
| return result; | |||
| } | |||
|
|
|||
| private static void AddToCallerCalleeMap(SyntaxNodeAnalysisContext context, Dictionary<IMethodSymbol, List<CallInfo>> callerToCalleeMap) | |||
| private static Dictionary<IMethodSymbol, List<CallInfo>> CreateCalleeToCallerMap(Dictionary<IMethodSymbol, List<CallInfo>> callerToCalleeMap) | |||
There was a problem hiding this comment.
Reviewers tip: this method didn't change. It just got moved.
This was referenced Mar 12, 2021
Bump Microsoft.VisualStudio.Threading.Analyzers from 16.7.54 to 16.9.60
BioWareRu/BioEngine.Core#420
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched GetSymbolInfo to IOperation in VSTHRD010.
In one simple repro, a build that took 46 seconds down to just over 1 second.
Fixes #701: a massive perf issue with VSTHRD010