Update eslint-config to enforce import types (#2594)

microsoft · Nov 29, 2023 · c704909 · c704909
1 parent 5306f6e
commit c704909
Show file tree

Hide file tree

Showing 98 changed files with 244 additions and 244 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -781,7 +781,7 @@
         "prepare": "husky install"
     },
     "devDependencies": {
-        "@microsoft/eslint-config-azuretools": "^0.2.1",
+        "@microsoft/eslint-config-azuretools": "^0.2.2",
         "@microsoft/vscode-azext-dev": "^2.0.2",
         "@types/dotenv": "^6.1.1",
         "@types/fs-extra": "^8.0.0",

diff --git a/src/AppServiceFileSystem.ts b/src/AppServiceFileSystem.ts
@@ -3,9 +3,9 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { FileTreeItem, getFile, ISiteFile, putFile } from "@microsoft/vscode-azext-azureappservice";
-import { AzExtTreeFileSystem, DialogResponses, IActionContext, IParsedError, parseError, UserCancelledError } from '@microsoft/vscode-azext-utils';
-import { FileStat, FileType, MessageItem, Uri } from "vscode";
+import { getFile, putFile, type FileTreeItem, type ISiteFile } from "@microsoft/vscode-azext-azureappservice";
+import { AzExtTreeFileSystem, DialogResponses, UserCancelledError, parseError, type IActionContext, type IParsedError } from '@microsoft/vscode-azext-utils';
+import { FileType, type FileStat, type MessageItem, type Uri } from "vscode";
 import { ext } from "./extensionVariables";
 import { localize } from "./localize";
 import { nonNullValue } from "./utils/nonNull";

diff --git a/src/WebAppResolver.ts b/src/WebAppResolver.ts
@@ -1,7 +1,7 @@
-import { Site } from "@azure/arm-appservice";
+import { type Site } from "@azure/arm-appservice";
 import { uiUtils } from "@microsoft/vscode-azext-azureutils";
-import { IActionContext, ISubscriptionContext, callWithTelemetryAndErrorHandling, nonNullProp, nonNullValue } from "@microsoft/vscode-azext-utils";
-import { AppResource, AppResourceResolver } from "@microsoft/vscode-azext-utils/hostapi";
+import { callWithTelemetryAndErrorHandling, nonNullProp, nonNullValue, type IActionContext, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
+import { type AppResource, type AppResourceResolver } from "@microsoft/vscode-azext-utils/hostapi";
 import { ResolvedWebAppResource } from "./tree/ResolvedWebAppResource";
 import { createWebSiteClient } from "./utils/azureClients";
 

diff --git a/src/commands/api/revealTreeItem.ts b/src/commands/api/revealTreeItem.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { AzExtTreeItem, callWithTelemetryAndErrorHandling, IActionContext } from "@microsoft/vscode-azext-utils";
+import { callWithTelemetryAndErrorHandling, type AzExtTreeItem, type IActionContext } from "@microsoft/vscode-azext-utils";
 import { ext } from "../../extensionVariables";
 
 export async function revealTreeItem(resourceId: string): Promise<void> {

diff --git a/src/commands/appSettings/addAppSetting.ts b/src/commands/appSettings/addAppSetting.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { AppSettingsTreeItem } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
 import { webAppFilter } from "../../constants";
 import { ext } from "../../extensionVariables";
 

diff --git a/src/commands/appSettings/deleteAppSettings.ts b/src/commands/appSettings/deleteAppSettings.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { AppSettingTreeItem } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
 import { webAppFilter } from "../../constants";
 import { ext } from "../../extensionVariables";
 

diff --git a/src/commands/appSettings/downloadAppSettings.ts b/src/commands/appSettings/downloadAppSettings.ts
@@ -3,11 +3,11 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { StringDictionary } from "@azure/arm-appservice";
+import { type StringDictionary } from "@azure/arm-appservice";
 import { confirmOverwriteSettings } from "@microsoft/vscode-azext-azureappservice";
-import { AppSettingsTreeItem, IAppSettingsClient } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext, UserCancelledError } from "@microsoft/vscode-azext-utils";
-import { DotenvParseOutput } from "dotenv";
+import { AppSettingsTreeItem, type IAppSettingsClient } from "@microsoft/vscode-azext-azureappsettings";
+import { UserCancelledError, type IActionContext } from "@microsoft/vscode-azext-utils";
+import { type DotenvParseOutput } from "dotenv";
 import * as fse from 'fs-extra';
 import * as os from 'os';
 import * as vscode from 'vscode';

diff --git a/src/commands/appSettings/editAppSetting.ts b/src/commands/appSettings/editAppSetting.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { AppSettingTreeItem } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
 import { webAppFilter } from "../../constants";
 import { ext } from "../../extensionVariables";
 

diff --git a/src/commands/appSettings/getLocalEnvironmentVariables.ts b/src/commands/appSettings/getLocalEnvironmentVariables.ts
@@ -2,10 +2,10 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-import { IActionContext, parseError } from '@microsoft/vscode-azext-utils';
+import { parseError, type IActionContext } from '@microsoft/vscode-azext-utils';
 import * as dotenv from 'dotenv';
 import * as fse from 'fs-extra';
-import { MessageItem } from 'vscode';
+import { type MessageItem } from 'vscode';
 import { localize } from '../../localize';
 
 export async function getLocalEnvironmentVariables(context: IActionContext, localSettingsPath: string, allowOverwrite: boolean = false): Promise<dotenv.DotenvParseOutput> {

diff --git a/src/commands/appSettings/renameAppSetting.ts b/src/commands/appSettings/renameAppSetting.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { AppSettingTreeItem } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
 import { webAppFilter } from "../../constants";
 import { ext } from "../../extensionVariables";
 

diff --git a/src/commands/appSettings/toggleSlotSetting.ts b/src/commands/appSettings/toggleSlotSetting.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { AppSettingTreeItem } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
 import { webAppFilter } from "../../constants";
 import { ext } from "../../extensionVariables";
 

diff --git a/src/commands/appSettings/uploadAppSettings.ts b/src/commands/appSettings/uploadAppSettings.ts
@@ -3,11 +3,11 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { StringDictionary } from "@azure/arm-appservice";
+import { type StringDictionary } from "@azure/arm-appservice";
 import { confirmOverwriteSettings } from "@microsoft/vscode-azext-azureappservice";
-import { AppSettingsTreeItem, IAppSettingsClient } from "@microsoft/vscode-azext-azureappsettings";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
-import * as dotenv from 'dotenv';
+import { AppSettingsTreeItem, type IAppSettingsClient } from "@microsoft/vscode-azext-azureappsettings";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
+import type * as dotenv from 'dotenv';
 import { Uri, window } from "vscode";
 import { envFileName, webAppFilter } from "../../constants";
 import { ext } from "../../extensionVariables";

diff --git a/src/commands/browseWebsite.ts b/src/commands/browseWebsite.ts
@@ -3,8 +3,8 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IActionContext } from '@microsoft/vscode-azext-utils';
-import { ISiteTreeItem } from '../tree/ISiteTreeItem';
+import { type IActionContext } from '@microsoft/vscode-azext-utils';
+import { type ISiteTreeItem } from '../tree/ISiteTreeItem';
 import { pickWebApp } from '../utils/pickWebApp';
 
 export async function browseWebsite(context: IActionContext, node?: ISiteTreeItem): Promise<void> {

diff --git a/src/commands/connections/addCosmosDBConnection.ts b/src/commands/connections/addCosmosDBConnection.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { AzExtParentTreeItem, AzExtTreeItem, IActionContext } from '@microsoft/vscode-azext-utils';
+import { type AzExtParentTreeItem, type AzExtTreeItem, type IActionContext } from '@microsoft/vscode-azext-utils';
 import { webAppFilter } from '../../constants';
 import { ext } from "../../extensionVariables";
 import { CosmosDBTreeItem } from '../../tree/CosmosDBTreeItem';

diff --git a/src/commands/connections/removeCosmosDBConnection.ts b/src/commands/connections/removeCosmosDBConnection.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IActionContext } from '@microsoft/vscode-azext-utils';
+import { type IActionContext } from '@microsoft/vscode-azext-utils';
 import { webAppFilter } from '../../constants';
 import { ext } from "../../extensionVariables";
 import { CosmosDBConnection } from '../../tree/CosmosDBConnection';

diff --git a/src/commands/connections/revealConnection.ts b/src/commands/connections/revealConnection.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IActionContext } from '@microsoft/vscode-azext-utils';
+import { type IActionContext } from '@microsoft/vscode-azext-utils';
 import { webAppFilter } from '../../constants';
 import { ext } from "../../extensionVariables";
 import { CosmosDBConnection } from '../../tree/CosmosDBConnection';

diff --git a/src/commands/connections/revealConnectionInAppSettings.ts b/src/commands/connections/revealConnectionInAppSettings.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { AzExtTreeItem, IActionContext } from '@microsoft/vscode-azext-utils';
+import { type AzExtTreeItem, type IActionContext } from '@microsoft/vscode-azext-utils';
 import { webAppFilter } from '../../constants';
 import { ext } from "../../extensionVariables";
 import { localize } from '../../localize';

diff --git a/src/commands/createSlot.ts b/src/commands/createSlot.ts
@@ -3,13 +3,13 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { SiteConfigResource } from "@azure/arm-appservice";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { type SiteConfigResource } from "@azure/arm-appservice";
+import { type IActionContext } from "@microsoft/vscode-azext-utils";
 import { ScmType, webAppFilter } from "../constants";
 import { ext } from "../extensionVariables";
 import { localize } from "../localize";
 import { DeploymentSlotsTreeItem } from "../tree/DeploymentSlotsTreeItem";
-import { SiteTreeItem } from "../tree/SiteTreeItem";
+import { type SiteTreeItem } from "../tree/SiteTreeItem";
 import { showCreatedWebAppMessage } from "./createWebApp/showCreatedWebAppMessage";
 import { editScmType } from "./deployments/editScmType";
 

diff --git a/src/commands/createWebApp/IWebAppWizardContext.ts b/src/commands/createWebApp/IWebAppWizardContext.ts
@@ -3,10 +3,10 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IAppServiceWizardContext } from '@microsoft/vscode-azext-azureappservice';
-import { ExecuteActivityContext } from '@microsoft/vscode-azext-utils';
-import { AppStackMajorVersion, AppStackMinorVersion } from './stacks/models/AppStackModel';
-import { JavaContainers, WebAppRuntimes, WebAppStack, WebAppStackValue } from './stacks/models/WebAppStackModel';
+import { type IAppServiceWizardContext } from '@microsoft/vscode-azext-azureappservice';
+import { type ExecuteActivityContext } from '@microsoft/vscode-azext-utils';
+import { type AppStackMajorVersion, type AppStackMinorVersion } from './stacks/models/AppStackModel';
+import { type JavaContainers, type WebAppRuntimes, type WebAppStack, type WebAppStackValue } from './stacks/models/WebAppStackModel';
 
 export type FullWebAppStack = {
     stack: WebAppStack;

diff --git a/src/commands/createWebApp/SetPostPromptDefaultsStep.ts b/src/commands/createWebApp/SetPostPromptDefaultsStep.ts
@@ -3,10 +3,10 @@
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
 
-import { SiteNameStep } from "@microsoft/vscode-azext-azureappservice";
+import { type SiteNameStep } from "@microsoft/vscode-azext-azureappservice";
 import { AzureWizardExecuteStep } from "@microsoft/vscode-azext-utils";
 import { localize } from "../../localize";
-import { IWebAppWizardContext } from "./IWebAppWizardContext";
+import { type IWebAppWizardContext } from "./IWebAppWizardContext";
 import { setPostPromptDefaults } from "./setPostPromptDefaults";
 
 export class SetPostPromptDefaultsStep extends AzureWizardExecuteStep<IWebAppWizardContext> {

diff --git a/src/commands/createWebApp/WebAppCreateStep.ts b/src/commands/createWebApp/WebAppCreateStep.ts
@@ -3,20 +3,20 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { NameValuePair, Site, SiteConfig, WebSiteManagementClient } from '@azure/arm-appservice';
-import { CustomLocation, WebsiteOS } from '@microsoft/vscode-azext-azureappservice';
+import { type NameValuePair, type Site, type SiteConfig, type WebSiteManagementClient } from '@azure/arm-appservice';
+import { WebsiteOS, type CustomLocation } from '@microsoft/vscode-azext-azureappservice';
 import { LocationListStep } from '@microsoft/vscode-azext-azureutils';
 import { AzureWizardExecuteStep } from '@microsoft/vscode-azext-utils';
-import { AppResource } from '@microsoft/vscode-azext-utils/hostapi';
-import { Progress } from 'vscode';
+import { type AppResource } from '@microsoft/vscode-azext-utils/hostapi';
+import { type Progress } from 'vscode';
 import * as constants from '../../constants';
 import { ext } from '../../extensionVariables';
 import { localize } from '../../localize';
 import { createWebSiteClient } from '../../utils/azureClients';
 import { nonNullProp } from '../../utils/nonNull';
-import { FullJavaStack, FullWebAppStack, IWebAppWizardContext } from './IWebAppWizardContext';
+import { type FullJavaStack, type FullWebAppStack, type IWebAppWizardContext } from './IWebAppWizardContext';
 import { getJavaLinuxRuntime } from './stacks/getJavaLinuxRuntime';
-import { WebAppStackValue, WindowsJavaContainerSettings } from './stacks/models/WebAppStackModel';
+import { type WebAppStackValue, type WindowsJavaContainerSettings } from './stacks/models/WebAppStackModel';
 
 export class WebAppCreateStep extends AzureWizardExecuteStep<IWebAppWizardContext> {
     public priority: number = 140;

diff --git a/src/commands/createWebApp/createWebApp.ts b/src/commands/createWebApp/createWebApp.ts
@@ -5,13 +5,13 @@
 
 import { AppInsightsCreateStep, AppInsightsListStep, AppKind, AppServicePlanCreateStep, AppServicePlanListStep, AppServicePlanSkuStep, CustomLocationListStep, ParsedSite, setLocationsTask, SiteNameStep } from "@microsoft/vscode-azext-azureappservice";
 import { LocationListStep, ResourceGroupCreateStep, ResourceGroupListStep, SubscriptionTreeItemBase, VerifyProvidersStep } from "@microsoft/vscode-azext-azureutils";
-import { AzExtParentTreeItem, AzureWizard, AzureWizardExecuteStep, AzureWizardPromptStep, IActionContext, ICreateChildImplContext, nonNullProp, parseError } from "@microsoft/vscode-azext-utils";
+import { AzureWizard, nonNullProp, parseError, type AzExtParentTreeItem, type AzureWizardExecuteStep, type AzureWizardPromptStep, type IActionContext, type ICreateChildImplContext } from "@microsoft/vscode-azext-utils";
 import { webProvider } from "../../constants";
 import { ext } from "../../extensionVariables";
 import { localize } from "../../localize";
 import { SiteTreeItem } from "../../tree/SiteTreeItem";
 import { createActivityContext } from "../../utils/activityUtils";
-import { IWebAppWizardContext } from "./IWebAppWizardContext";
+import { type IWebAppWizardContext } from "./IWebAppWizardContext";
 import { SetPostPromptDefaultsStep } from "./SetPostPromptDefaultsStep";
 import { setPrePromptDefaults } from "./setPrePromptDefaults";
 import { getCreatedWebAppMessage, showCreatedWebAppMessage } from "./showCreatedWebAppMessage";

diff --git a/src/commands/createWebApp/readAzConfig.ts b/src/commands/createWebApp/readAzConfig.ts
@@ -3,11 +3,11 @@
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
 
-import { WorkspaceFolder } from 'vscode';
-import { IDeployContext } from '@microsoft/vscode-azext-azureappservice';
+import { type IDeployContext } from '@microsoft/vscode-azext-azureappservice';
+import { type WorkspaceFolder } from 'vscode';
 import { cpUtils } from '../../utils/cpUtils';
 import { getSingleRootWorkspace } from '../../utils/workspace';
-import { IWebAppWizardContext } from './IWebAppWizardContext';
+import { type IWebAppWizardContext } from './IWebAppWizardContext';
 
 /**
  * Takes any number of Azure config properties to read and returns their configured values.