EOL warnings for V2/V3 runtimes #3771
Conversation
| const noPicksMessage = context.stackFilter ? | ||
| localize('noStacksFoundWithFilter', '$(warning) No stacks found for "{0}" on Azure Functions v{1}', context.stackFilter, majorVersion) : | ||
| localize('noStacksFound', '$(warning) No stacks found for Azure Functions v{0}', majorVersion); | ||
| const upgradeMessage = localize('eolWarning', '$(warning) No stacks found for Azure Functions v{0} due to being EOL. Upgrade your runtime version to see available stacks.') |
There was a problem hiding this comment.
Forgot to pass majorVersion into the localize call
src/FuncVersion.ts
Outdated
| { label: 'Azure Functions v3', data: FuncVersion.v3, description: '(EOL)' }, | ||
| { label: 'Azure Functions v2', data: FuncVersion.v2, description: '(EOL)' }, | ||
| { label: 'Azure Functions v1', data: FuncVersion.v1 }, { | ||
| label: localize('runtimeWarning', `$(extensions-warning-message) Azure Functions runtime v2.x and v3.x have reached the EOL. Learn more...`), |
There was a problem hiding this comment.
| label: localize('runtimeWarning', `$(extensions-warning-message) Azure Functions runtime v2.x and v3.x have reached the EOL. Learn more...`), | |
| label: localize('runtimeWarning', `$(extensions-warning-message) v2 and v3 have reached the end of life. Learn more...`), |
- It bothers me if we are inconsistent with "v2" vs "v2.x"
- I like spelling out acronyms at least once when possible, and this feel like a good place to do "end of life"
src/FuncVersion.ts
Outdated
| { label: 'Azure Functions v3', data: FuncVersion.v3, description: '(EOL)' }, | ||
| { label: 'Azure Functions v2', data: FuncVersion.v2, description: '(EOL)' }, | ||
| { label: 'Azure Functions v1', data: FuncVersion.v1 }, { | ||
| label: localize('runtimeWarning', `$(extensions-warning-message) Azure Functions runtime v2.x and v3.x have reached the EOL. Learn more...`), |
There was a problem hiding this comment.
It's a bit weird to have two "learn more"s in a row. Potential solutions:
- Get rid of one learn more. I guess I think the version overview page is more generally applicable. After all, this prompt in used in several scenarios, including cases where the user doesn't have an existing app they need to migrate.
- Update the learn more text. Maybe "Learn how to upgrade to v4..." and "Learn about Azure Functions versioning..."
| const noPicksMessage = context.stackFilter ? | ||
| localize('noStacksFoundWithFilter', '$(warning) No stacks found for "{0}" on Azure Functions v{1}', context.stackFilter, majorVersion) : | ||
| localize('noStacksFound', '$(warning) No stacks found for Azure Functions v{0}', majorVersion); | ||
| const upgradeMessage = localize('eolWarning', '$(warning) No stacks found for Azure Functions v{0} due to being EOL. Upgrade your runtime version to see available stacks.') |
There was a problem hiding this comment.
| const upgradeMessage = localize('eolWarning', '$(warning) No stacks found for Azure Functions v{0} due to being EOL. Upgrade your runtime version to see available stacks.') | |
| const upgradeMessage = localize('eolWarning', '$(warning) Azure Functions v{0} has reached end of life. Upgrade your runtime version to see available stacks. Learn more...') |
I think this message is the best place to have the migration guide link. In this case, we know they have an existing app locally using v3 (otherwise they wouldn't be seeing v3 stacks), so we know they need to migrate
There was a problem hiding this comment.
That makes sense. I guess knowing the migration guide isn't that useful when you're selecting a runtime version for the first time.
|
@nturinski it looks like we're using the 'warning symbol' for versions that are soon approaching end of life (Python 3.7 in your screenshot above) and the acronym 'EOL' for versions that have already approached end of life. Is this differentiation intended? I agree with other suggestions @ejizba made above. Thank you for working on this @nturinski ! |
|
New UI changes.
|
Fixes #3676
I was going back and forth on the UI a lot here. Feedback welcomed. @ejizba @MadhuraBharadwaj-MSFT