Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toast for GHCP4A #942

Merged
merged 14 commits into from
Oct 23, 2024
Merged

Add a toast for GHCP4A #942

merged 14 commits into from
Oct 23, 2024

Conversation

MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Oct 17, 2024

Closes #941

@MicroFish91 MicroFish91 marked this pull request as ready for review October 21, 2024 17:11
@MicroFish91 MicroFish91 requested a review from a team as a code owner October 21, 2024 17:11
* Conditionally show an install toast for the GitHub Copilot for Azure extension
*/
export function gitHubCopilotForAzureToast({ globalState }: ExtensionContext): void {
void callWithTelemetryAndErrorHandling('ghcp4aToast', async (context: IActionContext) => {
Copy link
Contributor

@bwateratmsft bwateratmsft Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this telemetry event is getting sent for all users on every activation, we should do context.telemetry.properties.isActivationEvent = 'true'

Otherwise we should suppress it anytime the notification is not shown

@MicroFish91 MicroFish91 merged commit cbc62dd into main Oct 23, 2024
3 checks passed
@MicroFish91 MicroFish91 deleted the mwf/ghcp-toast branch October 23, 2024 19:44
@microsoft microsoft locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast notification for GHCP4A
2 participants