appservice: Add flexDeploy method #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
previously approved these changes
Jul 18, 2023
…into nat/flexDeploy
appservice/src/SiteClient.ts
Outdated
| queryParameters: { remoteBuild?: boolean, Deployer?: string }): Promise<AzExtPipelineResponse> { | ||
| const client: ServiceClient = await createGenericClient(context, this._site.subscription); | ||
| const queryOptions = convertQueryParamsValuesToString(queryParameters); | ||
| const queryString = Object.keys(queryOptions).map(key => key + '=' + queryOptions[key]).join('&'); |
There was a problem hiding this comment.
Suggested change
| const queryString = Object.keys(queryOptions).map(key => key + '=' + queryOptions[key]).join('&'); | |
| const queryString = new URLSearchParams(queryParameters).toString(); |
Comment on lines
33
to
38
| const result: MessageItem = await context.ui.showWarningMessage(placeHolder, | ||
| { | ||
| modal: true, | ||
| stepName: 'confirmDestructiveDeployment', | ||
| learnMoreLink: options?.learnMoreLink | ||
| }, ...items); |
There was a problem hiding this comment.
This guy, not even prefixing with a nit...
There was a problem hiding this comment.
This is no nit, it's egregious
alexweininger
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions to handle deploying to CV2 plans. I added a method to allow us to customize the deployment confirmation prompt and some other options a bit more since a need arose for it.
I'll link the PR that uses this in a bit.