Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Fix gulp_webpack signature and default for getDefaultWebpackConfig #1814

Merged
merged 2 commits into from
Nov 8, 2024
Merged

dev: Fix gulp_webpack signature and default for getDefaultWebpackConfig #1814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed8a182
Fix gulp_webpack signature and default for getDefaultWebpackConfig
StephenWeatherford Nov 7, 2024
659b3a2
update version
StephenWeatherford Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export interface DefaultWebpackOptions {
verbosity?: Verbosity;

/**
* Webpack target
* Webpack target (defaults to 'node')
*/
target?: 'node' | 'webworker'

Expand Down Expand Up @@ -135,7 +135,7 @@ export declare function gulp_installVSCodeExtension(publisherId: string, extensi
/**
* Spawns a webpack process
*/
export declare function gulp_webpack(mode: string, target?: 'node' | 'webworker'): cp.ChildProcess;
export declare function gulp_webpack(mode: 'development' | 'production'): cp.ChildProcess;

/**
* Loose type to use for T2 versions of Azure SDKs. The Azure Account extension returns
Expand Down
2 changes: 1 addition & 1 deletion dev/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@microsoft/vscode-azext-dev",
"author": "Microsoft Corporation",
"version": "2.0.6",
"version": "2.1.0",
"description": "Common dev dependency tools for developing Azure extensions for VS Code",
"tags": [
"azure",
Expand Down
2 changes: 1 addition & 1 deletion dev/src/webpack/getDefaultWebpackConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export function getDefaultWebpackConfig(options: DefaultWebpackOptions): webpack

// vscode extensions run in a Node.js context on desktop, see https://webpack.js.org/configuration/node/
// vscode web extensions run with a "webworker" target, see https://webpack.js.org/configuration/target/#target
target: options.target,
target: options.target ?? 'node',
node: {
// For __dirname and __filename, let Node.js use its default behavior (i.e., gives the path to the packed extension.bundle.js file, not the original source file)
__filename: false,
Expand Down
Loading