Merge pull request #516 from EricCornelson/fixSetVariable

re-add setVariable handler
microsoft · Aug 28, 2019 · 966367f · 966367f
2 parents dc95d82 + 69bf51a
commit 966367f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/src/chrome/chromeDebugAdapter.ts b/src/chrome/chromeDebugAdapter.ts
@@ -9,7 +9,7 @@ import { ICommonRequestArgs, ILaunchRequestArgs, ISetBreakpointsArgs, ISetBreakp
     IAttachRequestArgs, IScopesResponseBody, IVariablesResponseBody,
     ISourceResponseBody, IThreadsResponseBody, IEvaluateResponseBody, IDebugAdapter,
     ICompletionsResponseBody, IToggleSkipFileStatusArgs,
-    ISetBreakpointResult, IRestartRequestArgs, IInitializeRequestArgs, ITelemetryPropertyCollector, IGetLoadedSourcesResponseBody, TimeTravelRuntime, IExceptionInfoResponseBody } from '../debugAdapterInterfaces';
+    ISetBreakpointResult, IRestartRequestArgs, IInitializeRequestArgs, ITelemetryPropertyCollector, IGetLoadedSourcesResponseBody, TimeTravelRuntime, IExceptionInfoResponseBody, ISetVariableResponseBody } from '../debugAdapterInterfaces';
 import { IChromeDebugAdapterOpts, ChromeDebugSession } from './chromeDebugSession';
 import { ChromeConnection } from './chromeConnection';
 import * as ChromeUtils from './chromeUtils';
@@ -1553,6 +1553,18 @@ export abstract class ChromeDebugAdapter implements IDebugAdapter {
         return this.chrome.Debugger.evaluateOnCallFrame(args);
     }
 
+    /* __GDPR__
+        "ClientRequest/setVariable" : {
+            "${include}": [
+                "${IExecutionResultTelemetryProperties}",
+                "${DebugCommonProperties}"
+            ]
+        }
+    */
+    public setVariable(args: DebugProtocol.SetVariableArguments): Promise<ISetVariableResponseBody> {
+        return this._variablesManager.setVariable(args);
+    }
+
     /* __GDPR__
         "ClientRequest/restartFrame" : {
             "${include}": [

diff --git a/src/chrome/variablesManager.ts b/src/chrome/variablesManager.ts
@@ -173,14 +173,6 @@ export class VariablesManager {
         error => Promise.reject(errors.errorFromEvaluate(error.message)));
     }
 
-    /* __GDPR__
-        "ClientRequest/setVariable" : {
-            "${include}": [
-                "${IExecutionResultTelemetryProperties}",
-                "${DebugCommonProperties}"
-            ]
-        }
-    */
     public setVariable(args: DebugProtocol.SetVariableArguments): Promise<ISetVariableResponseBody> {
         const handle = this._variableHandles.get(args.variablesReference);
         if (!handle) {