This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Expose chrome connection events and clients to extending class #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hookConnectionEvents function will allow custom adapter class that
extends ChromeDebugAdapter to listen to events that are not handled by
base ChromeDebugAdapter class, for example :
protected hookConnectionEvents(cc: ChromeConnection): void {
cc.on('Console.messageAdded', (msg) => this.onConsoleMessageAdded(msg));
return super.hookConnectionEvents(cc);
}
runConnection function will allow custom class to enable clients other
than Debugger and Runtime which are the only one currently enabled, for
example :
protected runConnection(): Promise<void>[] {
let a = super.runConnection();
a.push(this.chrome.Console.enable());
return a;
}
|
Hi @iradul, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Thanks for the PR! I agree that this is needed for subclassing, because you want to do this in that time between attach and firing 'initialized'. I'm actually in the middle of changing this to use the typed events instead of 'on', so note that |
roblourens
added a commit
that referenced
this pull request
Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hookConnectionEvents function will allow custom adapter class that
extends ChromeDebugAdapter to listen to events that are not handled by
base ChromeDebugAdapter class.
runConnection function will allow custom class to enable clients other
than Debugger and Runtime which are the only one currently enabled.
iradul/vscode-phantomjs-debug#5