Skip to content

Commit

Permalink
Inform users about Language Support extension update (#2597)
Browse files Browse the repository at this point in the history
  • Loading branch information
elahehrashedi authored Jun 13, 2022
1 parent 8123de3 commit 8d0498c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Improvements:
- Add support for "Configure", "Install" and "Test" tasks. [#2452](https://github.com/microsoft/vscode-cmake-tools/issues/2452)
- Add setting `cmake.ignoreCMakeListsMissing`. [PR #2537](https://github.com/microsoft/vscode-cmake-tools/pull/2537) [@ilg-ul](https://github.com/ilg-ul)
- Add support for "Clean" and "Clean Rebuild" tasks. [#2555](https://github.com/microsoft/vscode-cmake-tools/issues/2555)
- The extension for CMake language support is replaced. [PR #2267](https://github.com/microsoft/vscode-cmake-tools/pull/2267) [@josetr](https://github.com/josetr)

Bug Fixes:
- `Clean All Projects` menu item builds rather than cleans. [#2460](https://github.com/microsoft/vscode-cmake-tools/issues/2460)
Expand All @@ -25,7 +26,6 @@ Bug Fixes:
- Select the correct VS toolset for Ninja generators with CMake Presets. [#2423](https://github.com/microsoft/vscode-cmake-tools/issues/2423)
- Fix unhandled exception with CMakePresets.json. [#2117](https://github.com/microsoft/vscode-cmake-tools/issues/2117)
- Fix issues with compiler argument quoting when configuring IntelliSense. [#2563](https://github.com/microsoft/vscode-cmake-tools/pull/2563)
- Add support for cpptools API V6. [2508](https://github.com/microsoft/vscode-cmake-tools/issues/2508)

## 1.10.5
Bug Fixes:
Expand Down
9 changes: 9 additions & 0 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1795,6 +1795,15 @@ export async function activate(context: vscode.ExtensionContext) {
if (oldCMakeToolsExtension) {
await vscode.window.showWarningMessage(localize('uninstall.old.cmaketools', 'Please uninstall any older versions of the CMake Tools extension. It is now published by Microsoft starting with version 1.2.0.'));
}
// Inform the users that the language support extension has been modified.
const isOldLanguageSupportInformed = context.globalState.get('oldLanguageSupportInformed', false);
if (!isOldLanguageSupportInformed) {
const oldLanguageSupport = vscode.extensions.getExtension('twxs.cmake');
if (oldLanguageSupport) {
await context.globalState.update('oldLanguageSupportInformed', true);
void vscode.window.showInformationMessage(localize('uninstall.old.language.support', 'CMake Tools now bundles a new language support extension for CMakeLists.txt files and recommends that you uninstall the previous CMake language support extension by twxs.'));
}
}

// Start with a partial feature set view. The first valid CMake project will cause a switch to full feature set.
await enableFullFeatureSet(false);
Expand Down

0 comments on commit 8d0498c

Please sign in to comment.