Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-folder browse configurations incorrectly contain paths from other workspace folders #3155

Closed
Colengms opened this issue May 2, 2023 · 1 comment · Fixed by #3249
Closed
Assignees
Labels
Milestone

Comments

@Colengms
Copy link
Contributor

Colengms commented May 2, 2023

The C/C++ extension API provides an way (canProvideBrowseConfigurationsPerFolder field) for a configuration provider to indicate that it can provide a separate 'browse configuration' per workspace folder in multi-root scenarios. CMake Tools is providing a value of true for this, and is returning results from calls to provideFolderBrowseConfiguration.

We're seeing that CMake Tools incorrectly includes paths from workspace folder A in the browse paths for workspace folder B.

This causes a problem with exclusions. It's possible that workspace folder A may have excluded some subdirectories of its browse paths. When those same paths get associated with another folder, those exclusions are bypassed (not defined by the other workspace folder), resulting in files being parsed into the browse database that should have been excluded.

@benmcmorran benmcmorran self-assigned this May 4, 2023
@benmcmorran benmcmorran added this to the 1.15 milestone May 4, 2023
@gcampbell-msft
Copy link
Collaborator

@Colengms Do you possibly have an example project for a repro of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants