fix per folder provide browse configuration #3249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were returning the most recent stored browse configuration, which may be incorrect. Rather, we should return null if we don't have the browseConfiguration for the requested URI.
This change addresses item [#3155]
This changes the implementation of
provideFolderBrowseConfiguration
The following changes are proposed:
null
instead of a default / last storedworkspaceBrowseConfiguration
The purpose of this change
We were returning what effectively was the default or last stored
workspaceBrowseConfiguration
if we didn't have stored a browseConfiguration for that URI. This is incorrect as that default or last stored has no guarantee of actually applying. We instead returnnull
.Closes #3155