Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix per folder provide browse configuration #3249

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

gcampbell-msft
Copy link
Collaborator

We were returning the most recent stored browse configuration, which may be incorrect. Rather, we should return null if we don't have the browseConfiguration for the requested URI.

This change addresses item [#3155]

This changes the implementation of provideFolderBrowseConfiguration

The following changes are proposed:

  • Return null instead of a default / last stored workspaceBrowseConfiguration

The purpose of this change

We were returning what effectively was the default or last stored workspaceBrowseConfiguration if we didn't have stored a browseConfiguration for that URI. This is incorrect as that default or last stored has no guarantee of actually applying. We instead return null.

Closes #3155

We were returning the most recent stored browse configuration, which may be incorrect.
Rather, we should return null if we don't have the browseConfiguration for the requested URI.
@gcampbell-msft gcampbell-msft force-pushed the dev/gcampbell/FixPerFolderIntellisense branch from 3c5988f to 0d3e539 Compare July 19, 2023 20:32
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code base, but if it fixes the bug then that sounds good to me. I assume you got a repro from Colen.

@snehara99
Copy link
Contributor

I don't think the checks like that the return could be null. Does this check need to be bypassed or is there another option?

@gcampbell-msft
Copy link
Collaborator Author

I don't think the checks like that the return could be null. Does this check need to be bypassed or is there another option?

@snehara99 THis has been fixed, ping for review. Thanks!

@gcampbell-msft gcampbell-msft merged commit ce3dded into main Jul 20, 2023
@gcampbell-msft gcampbell-msft deleted the dev/gcampbell/FixPerFolderIntellisense branch July 20, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-folder browse configurations incorrectly contain paths from other workspace folders
3 participants