-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cmake gui #1019
feat: add cmake gui #1019
Conversation
@rogern01 So this is a GUI editor for the CMake cache? I suggest to name it appropriately and more specifically something like "CMake Cache Editor", respectively the commands "Edit Cache Variables", etc. |
@Zingam thanks for your feedback, I've renamed it to "CMake Cache Editor" and "Edit CMake Cache" respectively. |
@rogern01 can you have a look on the pipeline? |
src/cache-view.ts
Outdated
text-transform: uppercase; | ||
font-weight: bold; | ||
border: 1px solid transparent; | ||
border-image: linear-gradient(to bottom right, #b827fc 0%, #2c90fc 25%, #b8fd33 50%, #fec837 75%, #fd1892 100%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rainbow color border doesn't seem to fit with the overall feel of the extension. I would prefer a light/dark solid border here.
src/cache-view.ts
Outdated
height: 35px; | ||
background: linear-gradient(90deg, rgba(145,145,173,1) 0%, rgba(163,163,194,1) 36%, rgba(130,130,171,1) 61%, rgba(141,137,163,1) 100%); | ||
"> | ||
<th style="width: 30px">#</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unclear on the purpose of the #
column. It doesn't appear to have any content. Could you explain what it is for?
@andris I added some theming changes as a starting point for supporting light vs dark. Please reference cpptools as well. Not all of the elements have the same border colors or font colors and that still needs to be fixed. If you want to split this out into a follow up task so we can merge this, that is fine, but we need to complete it before releasing 1.5.0 |
Yes, I added this as a new entry in work item #1467. |
Yes, i’m ok with removing it |
I replaced this PR with #1490. Something is wrong with the branch and the extension won't activate in production mode. I reconstructed the changes in a new branch off develop and everything appears to work as expected. |
@gocarlos With this PR having been released for a few months now, do you need to keep your fork of the CMake Tools extension in the Marketplace, or can it be removed? |
I removed it now |
Thanks! |
This change addresses item #513
This changes
Adds a new option "Open Configuration" to the 3-dotted menu in the treeview section. Opens a WebView with the cached cmake options (only boolean so far). Cmake options can be changed and saved. After save, cmake is configured.