Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per-folder browse.path. #1156

Merged
merged 11 commits into from
Apr 6, 2020
Merged

Conversation

sean-mcmanus
Copy link
Contributor

Fix for #1073

@sean-mcmanus sean-mcmanus requested a review from a team April 2, 2020 01:46
@sean-mcmanus

This comment has been minimized.

@sean-mcmanus sean-mcmanus marked this pull request as ready for review April 2, 2020 03:03
@sean-mcmanus
Copy link
Contributor Author

Are there any multi-root CMake Tools automated tests? I didn't see any.

@bobbrow
Copy link
Member

bobbrow commented Apr 2, 2020

They are under test/extension-tests/multi-root-UI. There is a config in launch.json that will run them. The tests are not currently written to handle Windows very well. You should run them on linux or macOS.

src/cpptools.ts Outdated Show resolved Hide resolved
src/cpptools.ts Outdated Show resolved Hide resolved
src/cpptools.ts Show resolved Hide resolved
src/cpptools.ts Outdated Show resolved Hide resolved
@sean-mcmanus
Copy link
Contributor Author

They are under test/extension-tests/multi-root-UI. There is a config in launch.json that will run them. The tests are not currently written to handle Windows very well. You should run them on linux or macOS.

Ah, thanks...not sure how I didn't see that.

@sean-mcmanus
Copy link
Contributor Author

They are under test/extension-tests/multi-root-UI. There is a config in launch.json that will run them. The tests are not currently written to handle Windows very well. You should run them on linux or macOS.

Ah, thanks...not sure how I didn't see that.

I added some browsePath checks to the test.

@sean-mcmanus
Copy link
Contributor Author

@bobbrow Why is the continuous-integration/travis-ci stuck?

@bobbrow
Copy link
Member

bobbrow commented Apr 6, 2020

The travis CI is actually running, but the results are not being reported back to GitHub for some reason. I've been checking here for results: https://travis-ci.org/github/microsoft/vscode-cmake-tools/pull_requests. I also added my feedback to a bug report, but haven't heard anything back from the Travis team. https://travis-ci.community/t/status-checks-randomly-broken/7876

We need to switch this repo over to Azure pipelines anyway, so I haven't investigated much.

@sean-mcmanus sean-mcmanus merged commit 69b4079 into develop Apr 6, 2020
@sean-mcmanus
Copy link
Contributor Author

How did this PR get submitted? It was not intentional.

@bobbrow bobbrow deleted the seanmcm/browsePathFixes branch April 8, 2020 00:12
@bobbrow
Copy link
Member

bobbrow commented Apr 8, 2020

It's ok. I do want you to update the normalize cases to use platformNormalize instead though.

@bobbrow
Copy link
Member

bobbrow commented Apr 8, 2020

And it would probably be better to update the test to have unique target values in codeModel2 just so we don't have to worry about bugs sneaking through.

@sean-mcmanus
Copy link
Contributor Author

@bobbrow Sure, but I think I should delay that change until we ship our next C/C++ extension version, so 0.27.0 aren't broken...in case there's a reason to ship a CMake Tools update before then.

@bobbrow
Copy link
Member

bobbrow commented Apr 8, 2020

Can you create the PR now and we'll just wait to submit it then? If we don't, we're going to forget since this is a month or more away.

@sean-mcmanus
Copy link
Contributor Author

Can you create the PR now and we'll just wait to submit it then? If we don't, we're going to forget since this is a month or more away.

#1163

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants