-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for per-folder browse.path. #1156
Conversation
This comment has been minimized.
This comment has been minimized.
Are there any multi-root CMake Tools automated tests? I didn't see any. |
They are under |
Ah, thanks...not sure how I didn't see that. |
I added some browsePath checks to the test. |
@bobbrow Why is the continuous-integration/travis-ci stuck? |
The travis CI is actually running, but the results are not being reported back to GitHub for some reason. I've been checking here for results: https://travis-ci.org/github/microsoft/vscode-cmake-tools/pull_requests. I also added my feedback to a bug report, but haven't heard anything back from the Travis team. https://travis-ci.community/t/status-checks-randomly-broken/7876 We need to switch this repo over to Azure pipelines anyway, so I haven't investigated much. |
How did this PR get submitted? It was not intentional. |
It's ok. I do want you to update the normalize cases to use |
And it would probably be better to update the test to have unique target values in |
@bobbrow Sure, but I think I should delay that change until we ship our next C/C++ extension version, so 0.27.0 aren't broken...in case there's a reason to ship a CMake Tools update before then. |
Can you create the PR now and we'll just wait to submit it then? If we don't, we're going to forget since this is a month or more away. |
|
Fix for #1073