Fixes for GitHub issues 964 and 1084 #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
requested changes
Apr 8, 2020
…ct arm(64) kits if not installed.
bobbrow
requested changes
Apr 9, 2020
bobbrow
approved these changes
Apr 10, 2020
|
Please double-check my merge. There was a conflict with another feature that was recently submitted. |
bobbrow
reviewed
Apr 13, 2020
package.json
Outdated
| "ts-loader": "^6.0.4", | ||
| "ts-node": "^6.0.0", | ||
| "ts-loader": "^6.2.2", | ||
| "ts-node": "^8.8.1", |
There was a problem hiding this comment.
This new version of ts-node seems to be causing the build to fail on linux. Can you please fix it or revert the change?
There was a problem hiding this comment.
I saw your update, but the build still fails. Unfortunately, I don't think this was fixed.
There was a problem hiding this comment.
Yes I just saw it fails. I am trying reverting next.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for GitHub issue #1084:
Remove the default values for cmake.prefferedGenerators in package.json and use them later, only if the deduction process is not identifying any. Without this fix, Ninja and Unix Makefiles would always be preferred (when installed), when the user would not override these defaults in the settings and regardless of the preferred generator defined for the kit.
Fix for GitHub issue #964:
Always generate the VS kits with full information about the platforms, no defaults.
VS architecture becomes host architecture and is the arch before "".
Target architecture is the arch after "".
If no "_" is present in the end of the kit name, then the one architecture applies for host and target.
I am investigating some test failures (probably only baseline changes) but I am submitting the PR before, to get results also from the CI.