Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1183: add indication of active workspace to project outline #1199

Merged
merged 7 commits into from
Apr 27, 2020

Conversation

SchweizS
Copy link
Contributor

Changes:

  • Added indication of active workspace
  • added icon to select active workspace in project outline

Todo:

  • localization

#1183

@andreeis
Copy link
Contributor

The icon might not be the most relevant for the "change active workspace" operation. We would prefer 'gear' first, then if not possible the 'utility' icon. If you already tried other icons but got blocked in any way so you had to pick as a last resort the current (build like) icon then let us know and we will try to figure out. If you didn't try yet, please push another commit using one of the two recommended icons.

@SchweizS
Copy link
Contributor Author

i switched it to gear.
i just copy&pasted that part and forgot to change the icon to a better one.

src/extension.ts Outdated Show resolved Hide resolved
@SchweizS
Copy link
Contributor Author

localize('workspace.active', 'Active Workspace');
localize('workspace', 'Workspace');

those to keys should probably be added to the localization (tree.ts lines 461/463)

@andreeis andreeis merged commit 11084d2 into microsoft:develop Apr 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants