Skip configuring when cache is present and according setting is ON #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore various operations that require config change check. Configure on open remains unchanged.
bobbrow
reviewed
May 5, 2020
bobbrow
approved these changes
May 5, 2020
|
@bobbrow This change is missing documentation. Can't find this command on either https://vector-of-bool.github.io/docs/vscode-cmake-tools/settings.html or https://github.com/microsoft/vscode-cmake-tools |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue 984: #984
Allow the users to set when the extension should skip over configuring operations: new setting, plus verify if the cache file is present.
Add info log message so that the user is aware of the need to keep the cache up to date.
Functionality around configureOnOpen remains the same. The PR causes configuring to be skipped (even if state is evaluated as dirty) before building, debugging or launching.
No easy way to fix the symptom of reconfiguring after stopping a build. It would require some rewrite. Tracking with issue #1214.