Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cmake:hideBuildCommand context option. #1355

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Jul 7, 2020

The following changes are proposed:

  • New context option cmake:hideBuildCommand to hide the build command and keybindings.

This works like the already existing cmake:hideDebugCommand, and just does the same for the build actions.

The purpose of this change

This change allows other extensions to provide a custom F7 keybinding while the CMake extension is loaded.

@ghost
Copy link

ghost commented Jul 7, 2020

CLA assistant check
All CLA requirements met.

@tritao tritao changed the title Implement cmake.hideBuildCommand option. Implement cmake:hideBuildCommand context option. Jul 7, 2020
@tritao
Copy link
Contributor Author

tritao commented Jul 24, 2020

Is anyone able to take a look at these changes? Thanks

@bobbrow bobbrow added this to the 1.5.0 milestone Oct 2, 2020
@andreeis andreeis merged commit fadc2c2 into microsoft:develop Oct 7, 2020
@bobbrow bobbrow modified the milestones: 1.6.0, 1.5.0 Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants