Add package scripts to package.json #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Apr 12, 2021
package.json
Outdated
| @@ -1783,7 +1784,8 @@ | |||
| "tslint": "^5.20.1", | |||
| "typedoc": "^0.20.25", | |||
| "typescript": "^4.1.5", | |||
| "vscode": "^1.1.36", | |||
| "vsce": "^1.87.1", | |||
| "vscode": "^1.1.37", | |||
There was a problem hiding this comment.
We typically don't like to upgrade the vscode version unless we have to. We want to be able to run on the lowest possible version.
There was a problem hiding this comment.
Oh, sorry for that, I upgrade that because when I do yarn install it's failed locally
There was a problem hiding this comment.
Are you saying that this change requires the update to 1.1.37?
There was a problem hiding this comment.
That's not necessary, fixed
lygstate
force-pushed
the
package
branch
2 times, most recently
from
bb84f21 to
d207ffe
Compare
bobbrow
changed the title
So the developer can package vscode-cmake-tools easily.
bobbrow
approved these changes
Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the developer can package vscode-cmake-tools easily.
This change improve the building procedure for vsix