-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build and configure commands to show cmake commands without running them #1767
Conversation
It's not really a "dry run" so much as it is just logging the command line. A dry run tells you everything that would happen if that command was run. I would prefer we come up with a better name for the command. "CMake: Log Configure Command" or something like that would be more accurate, I think. You might also want to put focus on the output window when the command is run. |
I am getting this error while testing the branch: I think it is related to the latest regression we had, as your branch is up to date with the develop: #2006 I will test an older version of your branch i.e.
|
|
@elahehrashedi I tested the latest changes, and didn't see the issue in your comment. |
Copying the error message here:
|
@elahehrashedi The problem should be fixed now. Can you please test it? |
@andreeis I have tested the code and it is working. We can have this checked in for 1.9. |
Not sure how important this is, but for showConfigureCommand we write more (unuseful?) lines than for showBuildCommand. [main] Configuring folder: Project1 I am approving and will follow up whether we should hide the lines that are not the cmake configure command itself. It would just be querying in a few extra places for the boolean showCommandOnly or the trigger value and it would also require passing these further to some functions that do write these lines and which had no reason yet to have this parameter added to their prototype. |
Added configure and build commands to log corresponding cmake commands without running them.
According to Erika, these commands are mainly in response to feedback (primarily from VS users) that they didn't understand how settings map to the actual CMake command line, and the goal is to provide transparency so users can see how specific settings map to the CLI.
Current implementation requires cmake installed on the machine, since cmake-tools.ts and driver.ts aren't in a good state to get rid of this requirement, and I think it's okay as the target scenario isn't checking configure/build commands without cmake installed.