Don't add '-j' argument if parallelJobs <= 1 #2187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #1958
This changes behavior
The following changes are proposed:
The purpose of this change
Previously, the '-j' option would be passed to CMake even if the parellelJobs option was set to 1. This could cause issues with the build system. For example, passing the '-j' argument will cause CMake to actively remove the '/MP' flag in Visual C++, effectively disabling multi-processor compilation.
Other Notes/Information
Perhaps it would be best to add a configuration option to disable this automatic passing of '-j' altogether. However, this fix is sufficient when setting parellelJobs to 1.