-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize drive letter on windows for presets expanision #2665
Conversation
Thanks for the pull request. We'll do a bit of research and make sure this doesn't have any unintended consequences before we merge this in. |
Any progress? |
Sorry for the silence. We've been finishing up the remaining tasks for the 1.12 release which has taken a bit longer than expected. We're almost done and then we will come back to the outstanding PR's. |
@bobbrow I 'm not quite understand the failing CI result, is there any thing I need to do? |
Something changed in CI to make that test flaky. We'll rerun the test until it clears out. You don't need to worry about it. |
This changes is a workaround for microsoft/vscode#156781
The following changes are proposed:
When expanding macros for CmakePresets.json on windows, the drive letter will now be re-normalized to uppercase.
The purpose of this change
When access
workspaceFolder
by uri, VScode normalize drive letter on windows to lowercase for historical reason. This behavior will cause all expanded path start with a lowercase drive letter, while Visual Studio, at the same time, expanding it as uppercase. If a user is switching vscode and Visual Studio, they would have to regenerate cmake cache as cmake count all those paths as a different variables.Other Notes/Information