Search cmakelists only if user asks to configure #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also affects #3170 |
snehara99
reviewed
Oct 12, 2023
|
@vlavati Thanks for your contribution :) As a last step, could you please update CHANGELOG.md in the Improvements section of 1.16 with brief description of your change? You can also (optionally) give yourself credit (see the other entries in the changelog). |
|
@snehara99, It is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #3025
This changes visible behavior while user opens folder/workspace without CMakeLists.txt
The following changes are proposed:
The purpose of this change
Comments #3025 (comment) propose
to wait to the dialog to select cmakelists and dismiss the prompt.
But it looks that user needs to do that each time, when he opens folder/workspace.
The proposed change allows that user selects his choice to not configure project once (if he persists his choice).
If user wants to configure project later, he is able to run command "CMake: Configure".