Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get a test's WORKING_DIRECTORY in launch.json #3336

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

salo-dea
Copy link
Contributor

@salo-dea salo-dea commented Sep 8, 2023

This PR adds the option to get the correct working directory when debugging tests

The following changes are proposed:

  • Support usage of ${cmake.testWorkingDirectory} in launch.json to get the WORKING_DIRECTORY property of a test dynamically

The purpose of this change

  • Make it easier to debug tests in the same environment they would normally run in

…ty of a test in launch.json

To be used in "cwd" field for tests to have the same context when debugging as when running normally
@salo-dea
Copy link
Contributor Author

salo-dea commented Sep 8, 2023

@microsoft-github-policy-service agree

Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The code look good to me. Just add a brief entry to CHANGELOG.md and we can get this merged. Add to the 1.16 Features section and optionally give yourself credit (follow the examples of the other entries in the changelog).

@salo-dea
Copy link
Contributor Author

Awesome! Thank you :)

@benmcmorran benmcmorran added this to the 1.16 milestone Sep 13, 2023
Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging. I'm bypassing the failing Windows tests because we're seeing the same failure on other PRs and it's not related to this change.

@benmcmorran benmcmorran merged commit df0f09e into microsoft:main Sep 13, 2023
@salo-dea salo-dea deleted the ctest-debug-working-directory branch September 14, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants