Configure only one project for CMakelists.txt node in ProjectOutline #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcampbell-msft
requested changes
Oct 10, 2023
src/extension.ts
Outdated
| @@ -1876,7 +1876,13 @@ async function setup(context: vscode.ExtensionContext, progress?: ProgressHandle | |||
| vscode.commands.registerCommand('cmake.outline.editCacheUI', () => runCommand('editCacheUI')), | |||
| vscode.commands.registerCommand('cmake.outline.cleanRebuildAll', () => runCommand('cleanRebuildAll')), | |||
| // Commands for outline items | |||
| vscode.commands.registerCommand('cmake.outline.configure', (what: ProjectNode) => runCommand('configure', what.folder, false, what.sourceDirectory)), | |||
| vscode.commands.registerCommand('cmake.outline.configure', async (what: object) => { | |||
There was a problem hiding this comment.
It'd be good if we could restrict this type more than just object, something that only allows for ProjectNode or SourceFileNode.
There was a problem hiding this comment.
Thanks for review.
I've changed type annotation. Is it better?
There was a problem hiding this comment.
Yes! Everything looks good. Please add a Changelog entry and then I will approve and merge!
gcampbell-msft
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #3311
This changes visible behavior
The following changes are proposed:
The purpose of this change
The issue #3311 describes case with few projects in the ProjectOutline and it is possible to configure all projects, but there is no way to configure only a project that corresponds to the selected CMakeLists.txt. This PR changes the behavior of "configure" button to configure only one.