1.19 release merge from main #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reversed order of creating workspace browse configurations * updated tests * minimized change by only reversing fileGroups, and reverted tests
Co-authored-by: snehara99 <[email protected]>
* Remove unnecessary logging about string expansion * Fix typo in var name --------- Co-authored-by: snehara99 <[email protected]>
* Fix UI for settings override of package presets * Fix linter errors
Co-authored-by: snehara99 <[email protected]>
* File system APIs don't recognize ~ in paths and because of this the extension cannot properly interpret cmake file-api jsons to list targets. * Fix path typo --------- Co-authored-by: snehara99 <[email protected]>
* Add warning about not found VS installation instance and suggestion to re-scan kits, at the request of developers in the community. * Fix linter errors --------- Co-authored-by: snehara99 <[email protected]>
* initial commit * add better values * check notice and changelog before release version
…for presets (#3784) Co-authored-by: Garrett Campbell <[email protected]>
* colorization support in pre-release * update changelog
* Sort CMakeLists.txt by depth * Add changes to CHANGELOG.md --------- Co-authored-by: Garrett Campbell <[email protected]>
Co-authored-by: Garrett Campbell <[email protected]>
* fix ctest * only try to be smart about this in the test explorer entry points * updating comment * add try catch in debug createRunProfile
* get all presets to show in inherit * if new configure preset inherits from a user preset add to the user presets file * todo: finish update for different types of presets * checks for configure inherit and inherit. todo - check workflow * cleanup + mark as isUserPreset * undo use isuserpreset field * cleanup and changelog * cleanup * rename interface * update workflow preset to not extend preset + refactor inheritsfromuserpreset func * remove preset class fields from workflow preset * more workflow preset cleanup
…ious time (#3840) checks for exe again if it wasn't present the previous time
* Implement treeview for tests using test suite delimiter * Support regular expressions for delimiters * Improve UI string * Improve UI string * Address CR comments * Fix spacing * make sure to pass entry point through --------- Co-authored-by: Garrett Campbell <[email protected]> Co-authored-by: Garrett Campbell <[email protected]>
…3755) * presets + cmake.buildToolArgs: make sure `--` is added in all cases Fixes #3754. This issue was introduced in #3537 (cmake.buildToolsArgs was ignored for presets before). * Update changelog --------- Co-authored-by: Garrett Campbell <[email protected]>
* fix validation and pipeline, commented out vsce for testing * fix indentation for job * uncomment vsce
Fixes #3854. Support for watching multiple paths (cmakepresets.json/cmakeuserpresets.json/include files) was broken due to a Chokidar bug. Created a wrapper class to handle this scenario.
* fix * analyze user presets first because it's the base if it exists * more updates to fix include files and telemetry, still needs work and testing * ensure telemetry and other uses of 'all..Presets' is right * more fixes * ensure we don't duplicate cmakepresets in userpresets includes * remove unnecessary return * unionWith consistency * add test
* update defaults and remove popups * update changelog * fix types for configureOnOpen * fix eslint
Fixing broken links
Co-authored-by: Fatima Qarni <[email protected]>
* In short, with our recent updates, we are attempting to expand every string in the environment. This isn't a problem in most cases, but it exposed a bug in certain linux distros that use aliasing (environment variables). Therefore, we should be wiser about what we attempt to expand and only expand the presets environment variables the user has in their files. To do this, we need to be smarter about what we save in our cache and update by reference. * updated the other presets so they dont always have to reexpand configure preset. when they do, use plusIncludes which has the dev env cached if its been expanded before. also include the inherited parent envs * Fix environment expansion so we don't expand unnecessary variables - don't save the process.env or parent environment to the environment field of the cache. * Don't re-expand configure presets in the associated build/test/etc presets. * Fix expansion reporting issues with reporting an invalid config preset, and changing for each loop to a traditional for loop to make sure we dont have async issues with reporting. * fix validation bug for not being able to find a null config preset --------- Co-authored-by: Garrett Campbell <[email protected]>
* return expandedPreset, not preset * make sure user presets are considered
gcampbell-msft
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.19 release - final merge from main