Clang: Create kits for bundled LLVM in MSVC #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zingam
changed the title
bobbrow
requested changes
Nov 19, 2019
| bundled_clang_cl_paths.forEach(path_ => {clang_cl_paths.add(path_);}); | ||
|
|
||
| // Scan for kits | ||
| const vs_kits = scanForVSKits(pr); |
There was a problem hiding this comment.
What does changing the scanning order do? scanForVSKits used to be first. Is there a reason the order is changing?
There was a problem hiding this comment.
I just grouped the scanFor... functions together as in that way it is easier for me to follow the process flow. It doesn't change the extension's behavior.
Zingam
force-pushed
the
develop-Zingam-msvc-bundled-llvm
branch
from
cbf6ea8 to
a049fef
Compare
bobbrow
approved these changes
Dec 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #914
The following changes are proposed:
The purpose of this change
Other Notes/Information
This PR basically replaces: #894