Update HandleBars version. Bump up CMake Tools Release version to #1.2.3 #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
requested changes
Nov 27, 2019
CHANGELOG.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # What's New? | |||
|
|
|||
| ## 1.2.3 | |||
| Bug fixes: | |||
| - CTest status bar button text appears malformed. [#911] (https://github.com/microsoft/vscode-cmake-tools/issues/911) | |||
There was a problem hiding this comment.
there should not be a space between [] and (). If you put a space there, the hyperlink will not show up correctly. Can you please fix this and the other ones below (including for 1.2.2.)?
CHANGELOG.md
Outdated
| - Fix incorrect file associations when language is unset. [#926] (https://github.com/microsoft/vscode-cmake-tools/issues/911) | ||
|
|
||
| Improvements: | ||
| - Add telemetry for crashes. |
There was a problem hiding this comment.
I don't think this needs to be listed.
bobbrow
approved these changes
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update HandleBars to #4.5.3, because of security reasons.
Update CMake Tools version and changelog for #1.2.3 bug fixes release.