Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the command "Cosmos DB: Detach" to "Azure Databases: Detach" #2281

Open
v-xinda opened this issue Apr 28, 2024 · 1 comment · Fixed by #2415 · May be fixed by #2530
Open

Change the command "Cosmos DB: Detach" to "Azure Databases: Detach" #2281

v-xinda opened this issue Apr 28, 2024 · 1 comment · Fixed by #2415 · May be fixed by #2530
Labels
AT-CTI Created by CTI team

Comments

@v-xinda
Copy link

v-xinda commented Apr 28, 2024

OS: All
Build Version: 0.22.0
Regression: Not a regression

Repro Steps:
F1->Check the command "Detach"

Expect:
This command shows "Azure Databases: Detach".

Actual:
This command shows "Cosmos DB: Detach"
image

More Info:
This issue also reproduces for command "Cosmos DB: Attach Database Account".
image

@v-xinda v-xinda added the AT-CTI Created by CTI team label Apr 28, 2024
sevoku added a commit that referenced this issue Nov 13, 2024
to match attachDatabaseAccount

Fixes #2281
sevoku added a commit that referenced this issue Nov 13, 2024
to match attachDatabaseAccount

Fixes #2281
@sevoku sevoku closed this as completed in 5f9b4db Nov 20, 2024
@v-ruizh
Copy link

v-ruizh commented Nov 26, 2024

@sevoku This bug also reproduces on the latest main branch build 20241126.1, reopen it.

The commands are "Cosmos DB: Attach Database Account..." and "Cosmos DB: Detach Database Account..." in Command Palette now.

We have the below suggestions because that we can attach and detach both Cosmos DB accounts and PostgreSQL servers with the above 2 commands, not just include Cosmos DB accounts.

Suggestions:

  1. Change the attach command to "Azure Databases: Attach Database Account...".
  2. Change the detach command to "Azure Databases: Detach Database Account". (Remove "..." from the current detach command, because the connection can be detached directly without any confirmation dialog.)

@v-ruizh v-ruizh reopened this Nov 26, 2024
sevoku added a commit that referenced this issue Jan 13, 2025
@sevoku sevoku linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI Created by CTI team
Projects
None yet
2 participants