fix: Workaround to prevent Monaco loose a focus and handle "tab" key as text modifier #2433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2431
This pull request includes changes to the
MonacoEditor
component insrc/webviews/MonacoEditor.tsx
to improve focus management and accessibility. The most important changes include importing a new hook, using the hook to manage focus, and updating the component's return structure to include an input element for accessibility.Focus management improvements:
src/webviews/MonacoEditor.tsx
: Imported theuseUncontrolledFocus
hook from@fluentui/react-components
.src/webviews/MonacoEditor.tsx
: Utilized theuseUncontrolledFocus
hook within theMonacoEditor
component to manage focus attributes.src/webviews/MonacoEditor.tsx
: Updated the return structure of theMonacoEditor
component to include asection
element with focus attributes and aninput
element to prevent losing focus from the editor.