Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Declaration / Definition incorrectly adds the definition into a namespace it doesn't belong to #10464

Closed
sean-mcmanus opened this issue Feb 3, 2023 · 1 comment
Assignees
Labels
bug Feature: Create Declaration or Definition fixed Check the Milestone for the release in which the fix is or will be available. Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

test.cpp

namespace ns {

}

test.h

class foo {
public:
    foo();
};
  1. Do Create Declaration / Definition on the foo() constructor in test.h.

Bug: It adds the foo() definition to the namespace block that it doesn't belong to (IntelliSense squiggles). The bug doesn't repro in VS -- the definition is correctly placed after the namespace block.

@michelleangela
Copy link
Contributor

If there are at least 2 lines after the last function or namespace scope, then it doesn't repro.

So this is the same issue as #10500

@bobbrow bobbrow added this to the On Deck milestone Apr 17, 2023
@browntarik browntarik added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Create Declaration or Definition fixed Check the Milestone for the release in which the fix is or will be available. Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Development

No branches or pull requests

4 participants