Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra adjustments to textEdit for CDD #11110

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

browntarik
Copy link
Contributor

@browntarik browntarik commented Jun 20, 2023

Addresses: #10500, #10464

This change removes the adjustments that were previously added to account for two text edits.

@browntarik
Copy link
Contributor Author

browntarik commented Jun 21, 2023

Existing Known Issue:

For the scenario where a user generates a definition in a source file with no #include with an existing namespace and another existing function that is declared in the header file it will misplace the definition due to miscalculation of neighboring functions.

example.cpp

namespace uniqueName {
int GlobalFunction3()
{
return 0;
}
}

example.h

#pragma once
namespace uniqueName {
int GlobalFunction2();
int GlobalFunction3();
template
int GlobalFunction5();
}
We will check this in because the scenario is unlikely. Otherwise, testing shows the change works out.

@browntarik browntarik merged commit 4037db9 into main Jun 21, 2023
@browntarik browntarik deleted the browntarik/fixCDDBug branch June 21, 2023 19:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants